From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, pierrick.bouvier@linaro.org,
qemu-stable@nongnu.org, alex.bennee@linaro.org
Subject: Re: [PATCH 1/2] meson: define qemu_isa_flags
Date: Mon, 7 Oct 2024 07:55:58 -0700 [thread overview]
Message-ID: <9d0c83aa-a22d-43b1-bd96-6ef64ea9ae96@linaro.org> (raw)
In-Reply-To: <CABgObfYu2jqKMJ_xrNv1Ci5B2NSxrcaaUO2piu=3o=Ca=Sn_tQ@mail.gmail.com>
On 10/7/24 07:48, Paolo Bonzini wrote:
> On Mon, Oct 7, 2024 at 4:46 PM Richard Henderson
> <richard.henderson@linaro.org> wrote:
>>> - qemu_common_flags = ['-march=i486'] + qemu_common_flags
>>> + qemu_isa_flags = ['-march=i486']
>>
>> Use += ?
>
> Here the qemu_isa_flags are known to be empty.
... until we add something else beforehand and fail to update.
Surely it's easier to assume that it's not empty.
> I just didn't want to change behavior here (especially since this
> patch was already about subtle changes in behavior). But you're right
> that at least within qemu_isa_flags the order should not matter.
Fair enough.
r~
next prev parent reply other threads:[~2024-10-07 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 8:43 [PATCH v2 0/2] meson: ensure we enable CMPXCHG128 on x86_64 Paolo Bonzini
2024-10-07 8:43 ` [PATCH 1/2] meson: define qemu_isa_flags Paolo Bonzini
2024-10-07 14:46 ` Richard Henderson
2024-10-07 14:48 ` Paolo Bonzini
2024-10-07 14:55 ` Richard Henderson [this message]
2024-10-07 14:57 ` Michael Tokarev
2024-10-07 8:43 ` [PATCH 2/2] meson: ensure -mcx16 is passed when detecting ATOMIC128 Paolo Bonzini
2024-10-07 14:46 ` Richard Henderson
2024-10-07 9:01 ` [PATCH v2 0/2] meson: ensure we enable CMPXCHG128 on x86_64 Michael Tokarev
2024-10-07 9:58 ` Alex Bennée
2024-10-07 16:40 ` Pierrick Bouvier
-- strict thread matches above, loose matches on Subject: below --
2024-10-07 17:23 [PATCH v3 " Paolo Bonzini
2024-10-07 17:23 ` [PATCH 1/2] meson: define qemu_isa_flags Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d0c83aa-a22d-43b1-bd96-6ef64ea9ae96@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).