From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Nicholas Piggin <npiggin@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2] ppc440_pcix: Do not expose a bridge device on PCI bus
Date: Mon, 15 Apr 2024 16:47:10 +0200 [thread overview]
Message-ID: <9d11f4fa-8153-49b7-8920-7edb61ef36f7@linaro.org> (raw)
In-Reply-To: <81128dae-f01e-ff40-c2cc-ff721dfdf288@eik.bme.hu>
On 14/4/24 15:00, BALATON Zoltan wrote:
> On Sat, 13 Apr 2024, Philippe Mathieu-Daudé wrote:
>> On 11/4/24 21:24, BALATON Zoltan wrote:
>>> Real 460EX SoC apparently does not expose a bridge device and having
>>> it appear on PCI bus confuses an AmigaOS file system driver that uses
>>> this to detect which machine it is running on.
>>>
>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>> ---
>>> Here's another version that keeps the values and only drops the device
>>> so it's even less likely it could break anything, in case this can be
>>> accepted for 9.0.
>>>
>>> hw/pci-host/ppc440_pcix.c | 11 ++++-------
>>> 1 file changed, 4 insertions(+), 7 deletions(-)
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Thanks. Nick, could you ack this please so it could be merged if you
> won't send more pull requests? (I'm the maintainer of this file as it's
> only used by sam460ex so maybe an ack is not needed but it could help to
> show you have no problem with it.)
No need, queued, thanks.
prev parent reply other threads:[~2024-04-15 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 19:24 [PATCH v2] ppc440_pcix: Do not expose a bridge device on PCI bus BALATON Zoltan
2024-04-12 20:49 ` BALATON Zoltan
2024-04-13 10:02 ` Philippe Mathieu-Daudé
2024-04-14 13:00 ` BALATON Zoltan
2024-04-15 14:47 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d11f4fa-8153-49b7-8920-7edb61ef36f7@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=npiggin@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).