From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com, mst@redhat.com
Subject: Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register
Date: Wed, 24 Jun 2020 09:47:30 +0200 [thread overview]
Message-ID: <9d1c30ab-9944-712a-16e7-c2d3240f23e1@redhat.com> (raw)
In-Reply-To: <20200623161852.19477-2-pbonzini@redhat.com>
On 23/06/2020 18.18, Paolo Bonzini wrote:
> The memory region ops have min_access_size == 4 so obey it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qtest/usb-hcd-ehci-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/usb-hcd-ehci-test.c b/tests/qtest/usb-hcd-ehci-test.c
> index 5251d539e9..c51e8bb223 100644
> --- a/tests/qtest/usb-hcd-ehci-test.c
> +++ b/tests/qtest/usb-hcd-ehci-test.c
> @@ -96,7 +96,7 @@ static void pci_ehci_port_1(void)
> static void pci_ehci_config(void)
> {
> /* hands over all ports from companion uhci to ehci */
> - qpci_io_writew(ehci1.dev, ehci1.bar, 0x60, 1);
> + qpci_io_writel(ehci1.dev, ehci1.bar, 0x60, 1);
> }
>
> static void pci_uhci_port_2(void)
Passes "make check-qtest-x86_64" on a s390x host, too:
Tested-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-06-24 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 16:18 [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register Paolo Bonzini
2020-06-23 20:56 ` Michael S. Tsirkin
2020-06-24 5:59 ` Paolo Bonzini
2020-06-24 7:47 ` Thomas Huth [this message]
2020-06-24 8:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d1c30ab-9944-712a-16e7-c2d3240f23e1@redhat.com \
--to=thuth@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).