Re: [Qemu-devel] [PATCH 04/19] hw/core: Declare device little or big endian

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 8/26/19 4:21 PM, Tony Nguyen wrote:
> For each device declared with DEVICE_NATIVE_ENDIAN, find the set of
> targets from the set of target/hw/*/device.o.
> 
> If the set of targets are all little or all big endian, re-declare
> as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN respectively.
> 
> Then, on inspection:
> - if ununsed, re-declare as DEVICE_HOST_ENDIAN.

In all the series: 'ununsed' -> 'unused'


> - if max/min size=1, re-declare as DEVICE_HOST_ENDIAN.
> - if just a bit bucket, re-delcare as DEVICE_HOST_ENDIAN

In all the series: 're-delcare' -> 're-declare'

> - if PCI, re-declare as DEVICE_LITTLE_ENDIAN.
> - if for {ARM|unicore32} only, re-declare as DEVICE_LITTLE_ENDIAN.
> - if for SPARC only, re-declare as DEVICE_BIG_ENDIAN.
> 
> Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
> ---
>   hw/core/empty_slot.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/empty_slot.c b/hw/core/empty_slot.c
> index 3ba450e1ca..2785b6acf9 100644
> --- a/hw/core/empty_slot.c
> +++ b/hw/core/empty_slot.c
> @@ -49,7 +49,7 @@ static void empty_slot_write(void *opaque, hwaddr addr,
>   static const MemoryRegionOps empty_slot_ops = {
>       .read = empty_slot_read,
>       .write = empty_slot_write,
> -    .endianness = DEVICE_NATIVE_ENDIAN,
> +    .endianness = DEVICE_HOST_ENDIAN,

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>   };
>   
>   void empty_slot_init(hwaddr addr, uint64_t slot_size)
>