From: Paolo Bonzini <pbonzini@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"Peter Xu" <peterx@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH qemu v7] memory/iommu: QOM'fy IOMMU MemoryRegion
Date: Thu, 8 Jun 2017 17:30:57 +0200 [thread overview]
Message-ID: <9d33a605-3e14-249c-b632-3d90f4e0bb50@redhat.com> (raw)
In-Reply-To: <20170608145803.GI25805@umbus.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 477 bytes --]
On 08/06/2017 16:58, David Gibson wrote:
> So, doing that via the standard macro wrappers would be slow, because
> it does type verification. However, looking up the class function is
> fundamentally:
>
> ((IOMMUMemoryRegionClass *)(((Object *)mr)->class))->translate
>
> i.e. two pointers followed, which is just the same as
> mr->ops->translate
Fair enough. On the other hand it's a bigger change so I think it's
better to keep it separate.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-06-08 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 8:32 [Qemu-devel] [PATCH qemu v7] memory/iommu: QOM'fy IOMMU MemoryRegion Alexey Kardashevskiy
2017-06-08 7:42 ` David Gibson
2017-06-08 13:59 ` Paolo Bonzini
2017-06-08 14:51 ` David Gibson
2017-06-08 14:28 ` Alexey Kardashevskiy
2017-06-08 14:40 ` Paolo Bonzini
2017-06-08 14:58 ` David Gibson
2017-06-08 15:30 ` Paolo Bonzini [this message]
2017-06-08 23:49 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d33a605-3e14-249c-b632-3d90f4e0bb50@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).