From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Helge Konetzka <hk@zapateado.de>
Subject: Re: [PATCH for-9.0 3/4] vga: adjust dirty memory region if pel panning is active
Date: Tue, 2 Apr 2024 13:43:36 +0200 [thread overview]
Message-ID: <9d64b14b-3c4e-41bb-b79d-1ee5d4df3eac@linaro.org> (raw)
In-Reply-To: <20240402113408.18048-4-pbonzini@redhat.com>
On 2/4/24 13:34, Paolo Bonzini wrote:
> When pel panning is active, one more byte is read from each of the VGA
> memory planes. This has to be accounted in the computation of region_end,
> otherwise vga_draw_graphic() fails an assertion:
>
> qemu-system-i386: ../system/physmem.c:946: cpu_physical_memory_snapshot_get_dirty: Assertion `start + length <= snap->end' failed.
>
> Reported-by: Helge Konetzka <hk@zapateado.de>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2244
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/display/vga.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-04-02 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 11:34 [PATCH for-9.0 0/4] vga: fix assertion failure with 4- and 16-color modes Paolo Bonzini
2024-04-02 11:34 ` [PATCH for-9.0 1/4] vga: merge conditionals on shift control register Paolo Bonzini
2024-04-02 11:40 ` Philippe Mathieu-Daudé
2024-04-02 11:34 ` [PATCH for-9.0 2/4] vga: move computation of dirty memory region later Paolo Bonzini
2024-04-02 11:41 ` Philippe Mathieu-Daudé
2024-04-02 11:34 ` [PATCH for-9.0 3/4] vga: adjust dirty memory region if pel panning is active Paolo Bonzini
2024-04-02 11:43 ` Philippe Mathieu-Daudé [this message]
2024-04-02 11:34 ` [PATCH for-9.0 4/4] vga: do not treat horiz pel panning value of 8 as "enabled" Paolo Bonzini
2024-04-02 11:34 ` [PATCH for-9.1 5/4] vga: optimize computation of dirty memory region Paolo Bonzini
2024-04-02 11:34 ` [PATCH for-9.1 6/4] vga: move dirty memory region code together Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d64b14b-3c4e-41bb-b79d-1ee5d4df3eac@linaro.org \
--to=philmd@linaro.org \
--cc=hk@zapateado.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).