From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
"Vanderson M . do Rosario" <vandersonmr2@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PULL 3/5] tcg: add perfmap and jitdump
Date: Fri, 30 Jun 2023 14:39:06 +0200 [thread overview]
Message-ID: <9d6b93c20340059f1a2fbea4a7a531e2e35ba34d.camel@linux.ibm.com> (raw)
In-Reply-To: <e122d115-0d0f-59d2-b593-2210ca1118df@linaro.org>
On Thu, 2023-06-29 at 14:59 +0200, Richard Henderson wrote:
> On 6/29/23 13:31, Philippe Mathieu-Daudé wrote:
> > > diff --git a/tcg/tcg.c b/tcg/tcg.c
> > > index da91779890..9b7df71e7a 100644
> > > --- a/tcg/tcg.c
> > > +++ b/tcg/tcg.c
> > > @@ -61,6 +61,7 @@
> > > #include "exec/log.h"
> > > #include "tcg/tcg-ldst.h"
> > > #include "tcg-internal.h"
> > > +#include "accel/tcg/perf.h"
> >
> > Is it OK to include an header from QEMU's accel/tcg/ here?
> > I thought we wanted to keep tcg/ kinda independant (or maybe
> > this is already too late and this isn't a concern anymore).
>
> It's not ideal, no. Perf really should live in tcg/.
>
>
> r~
This would require to somehow get rid of this:
#if defined(TARGET_I386)
q[insn].address -= tb->cs_base;
#endif
I'll try to come up with a patch.
next prev parent reply other threads:[~2023-06-30 12:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 22:36 [PULL 0/5] tcg patch queue Richard Henderson
2023-01-16 22:36 ` [PULL 1/5] linux-user: Clean up when exiting due to a signal Richard Henderson
2023-01-16 22:36 ` [PULL 2/5] accel/tcg: Add debuginfo support Richard Henderson
2023-01-16 22:36 ` [PULL 3/5] tcg: add perfmap and jitdump Richard Henderson
2023-06-02 17:21 ` Peter Maydell
2023-06-03 20:35 ` Ilya Leoshkevich
2023-06-29 11:31 ` Philippe Mathieu-Daudé
2023-06-29 12:59 ` Richard Henderson
2023-06-30 12:39 ` Ilya Leoshkevich [this message]
2023-06-30 13:24 ` Richard Henderson
2023-12-07 9:51 ` Philippe Mathieu-Daudé
2025-05-19 15:07 ` Peter Maydell
2023-01-16 22:36 ` [PULL 4/5] util/bufferiszero: Use __attribute__((target)) for avx2/avx512 Richard Henderson
2023-01-16 22:36 ` [PULL 5/5] accel/tcg: Split out cpu_exec_{setjmp,loop} Richard Henderson
2023-01-17 15:47 ` [PULL 0/5] tcg patch queue Peter Maydell
2023-01-20 9:41 ` Thomas Huth
2023-01-20 10:50 ` Alex Bennée
2023-01-20 10:53 ` Ilya Leoshkevich
2023-01-20 12:51 ` Thomas Huth
2023-01-20 16:49 ` Alex Bennée
2023-01-21 6:07 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d6b93c20340059f1a2fbea4a7a531e2e35ba34d.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vandersonmr2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).