From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] Split ISA and sysbus versions of m48t59 device
Date: Fri, 4 Nov 2016 08:28:25 -0500 [thread overview]
Message-ID: <9d852a99-806e-2c1d-da7f-adbce33eb96a@redhat.com> (raw)
In-Reply-To: <878tszr1c6.fsf@dusky.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
On 11/04/2016 05:22 AM, Markus Armbruster wrote:
> Needs a rebase. First error:
>
> CC hw/timer/m48t59.o
> In file included from /work/armbru/qemu/include/exec/cpu-common.h:7:0,
> from /work/armbru/qemu/include/exec/memory.h:24,
> from /work/armbru/qemu/include/hw/isa/isa.h:6,
> from /work/armbru/qemu/hw/timer/m48t59-isa.c:25:
> /work/armbru/qemu/include/exec/hwaddr.h:11:9: error: unknown type name ‘uint64_t’
> typedef uint64_t hwaddr;
> ^
>
>> index 0000000..3a521dc
>> --- /dev/null
>> +++ b/hw/timer/m48t59-isa.c
>> + * THE SOFTWARE.
>> + */
>> +#include "hw/isa/isa.h"
Probably because you forgot osdep.h as the first include.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-11-04 13:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 4:23 [Qemu-devel] [PATCH 0/3] Allow ISA to be disabled on some platforms David Gibson
2016-10-17 4:23 ` [Qemu-devel] [PATCH 1/3] Split serial-isa into its own config option David Gibson
2016-10-17 4:23 ` [Qemu-devel] [PATCH 2/3] Allow ISA bus to be configured out David Gibson
2016-10-17 4:23 ` [Qemu-devel] [PATCH 3/3] Split ISA and sysbus versions of m48t59 device David Gibson
2016-11-04 10:22 ` Markus Armbruster
2016-11-04 13:28 ` Eric Blake [this message]
2016-11-08 6:12 ` David Gibson
2016-10-17 4:36 ` [Qemu-devel] [PATCH 0/3] Allow ISA to be disabled on some platforms no-reply
-- strict thread matches above, loose matches on Subject: below --
2016-11-21 5:04 [Qemu-devel] [PATCH 1/3] Split serial-isa into its own config option David Gibson
2016-11-21 5:04 ` [Qemu-devel] [PATCH 3/3] Split ISA and sysbus versions of m48t59 device David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d852a99-806e-2c1d-da7f-adbce33eb96a@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).