From: Gavin Shan <gshan@redhat.com>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Juraj Marcin <jmarcin@redhat.com>
Subject: Re: [PATCH v1] virtio-mem: don't warn about THP sizes on a kernel without THP support
Date: Fri, 13 Sep 2024 10:16:09 +1000 [thread overview]
Message-ID: <9d879983-e3a7-4832-8bfa-a3db37504244@redhat.com> (raw)
In-Reply-To: <20240910163433.2100295-1-david@redhat.com>
On 9/11/24 2:34 AM, David Hildenbrand wrote:
> If the config directory in sysfs does not exist at all, we are dealing
> with a system that does not support THPs. Simply use 1 MiB block size
> then, instead of warning "Could not detect THP size, falling back to
> ..." and falling back to the default THP size.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Gavin Shan <gshan@redhat.com>
> Cc: Juraj Marcin <jmarcin@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/virtio/virtio-mem.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
prev parent reply other threads:[~2024-09-13 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 16:34 [PATCH v1] virtio-mem: don't warn about THP sizes on a kernel without THP support David Hildenbrand
2024-09-10 18:26 ` Michael S. Tsirkin
2024-09-10 18:44 ` David Hildenbrand
2024-09-13 0:16 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d879983-e3a7-4832-8bfa-a3db37504244@redhat.com \
--to=gshan@redhat.com \
--cc=david@redhat.com \
--cc=jmarcin@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).