qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, "Riku Voipio" <riku.voipio@iki.fi>,
	"Guido Günther" <agx@sigxcpu.org>
Subject: Re: [Qemu-devel] [PATCH v5 09/10] linux-user/strace: Improve bind() output
Date: Sat, 13 Oct 2018 20:27:49 +0200	[thread overview]
Message-ID: <9d8e318c-719c-c6ec-37c3-f2355ab8e7be@vivier.eu> (raw)
In-Reply-To: <20181010223656.31632-10-f4bug@amsat.org>

On 11/10/2018 00:36, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-By: Guido Günther <agx@sigxcpu.org>
> ---
>  linux-user/strace.c    | 13 +++++++++++++
>  linux-user/strace.list |  2 +-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 14ec5f9f23..9f7480c449 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -1966,6 +1966,19 @@ print_socketcall(const struct syscallname *name,
>  }
>  #endif
>  
> +#if defined(TARGET_NR_bind)
> +static void
> +print_bind(const struct syscallname *name,
> +           abi_long arg0, abi_long arg1, abi_long arg2,
> +           abi_long arg3, abi_long arg4, abi_long arg5)
> +{
> +    print_syscall_prologue(name);
> +    print_sockfd(arg0, 0);

print_sockfd() is only defined if TARGET_NR_socketcall is defined, so in
this case it can be undefined.

Thanks,
Laurent

      parent reply	other threads:[~2018-10-13 18:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 22:36 [Qemu-devel] [PATCH v5 00/10] linux-user: strace improvements Philippe Mathieu-Daudé
2018-10-10 22:36 ` [Qemu-devel] [PATCH v5 01/10] linux-user/syscall: Verify recvfrom(addr) is user-writable Philippe Mathieu-Daudé
2018-10-14 13:19   ` Laurent Vivier
2018-10-10 22:36 ` [Qemu-devel] [PATCH v5 02/10] linux-user/strace: Display invalid pointer in print_timeval() Philippe Mathieu-Daudé
2018-10-10 22:36 ` [Qemu-devel] [PATCH v5 03/10] linux-user/strace: Add print_timezone() Philippe Mathieu-Daudé
2018-10-10 22:36 ` [Qemu-devel] [PATCH v5 04/10] linux-user/strace: Improve settimeofday() Philippe Mathieu-Daudé
2018-10-10 22:36 ` [Qemu-devel] [PATCH v5 05/10] linux-user/syscall: Introduce target_sockaddr_nl Philippe Mathieu-Daudé
2018-10-10 22:36 ` [Qemu-devel] [PATCH v5 06/10] linux-user/strace: Dump AF_NETLINK sockaddr content Philippe Mathieu-Daudé
2018-10-10 22:36 ` [Qemu-devel] [PATCH v5 07/10] linux-user/strace: Add print_sockfd() Philippe Mathieu-Daudé
2018-10-10 22:36 ` [Qemu-devel] [PATCH v5 08/10] linux-user/strace: Let print_sockaddr() have a 'last' argument Philippe Mathieu-Daudé
     [not found] ` <20181010223656.31632-10-f4bug@amsat.org>
2018-10-13 18:27   ` Laurent Vivier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d8e318c-719c-c6ec-37c3-f2355ab8e7be@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=agx@sigxcpu.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).