From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D525FC25B7A for ; Wed, 22 May 2024 13:01:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9laJ-0006np-JQ; Wed, 22 May 2024 09:00:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9la2-0006ii-9Y for qemu-devel@nongnu.org; Wed, 22 May 2024 09:00:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9lZz-00033R-Ai for qemu-devel@nongnu.org; Wed, 22 May 2024 09:00:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716382826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OHQlMcUmbYKr51UNkAqNZl52Y5Y2mzhZICt4caD6aJA=; b=KrBk3Lrt/eRMkZ9nik5x5psh8bad6U5lioQCO9/JtOu5B1NAg3Qe3fRbAmRPoNpV7eX47X dGNtHdV1P0a7X6XxgFq1d3aPGFYiSMKkFLH7zIQhogLARdb/19ce2fRq1jdH1Q6l6mItY0 Njn/CfgAyOmWHrpy0sPMS3u+Gs8E354= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-UfATnz62NX-Lz9SJS7LvnA-1; Wed, 22 May 2024 09:00:25 -0400 X-MC-Unique: UfATnz62NX-Lz9SJS7LvnA-1 Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-4df2e5473feso6281839e0c.2 for ; Wed, 22 May 2024 06:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716382824; x=1716987624; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OHQlMcUmbYKr51UNkAqNZl52Y5Y2mzhZICt4caD6aJA=; b=veEVq51b6/oOnrTSJ8JeanV7N32p2cs2eqRb+m5J0kDbPzmkUjFIb6JjI9ZB/m22LJ pO1xQXxeoYLh48jNmwDmPh43/HmgqlykDtvx6ZQZkoVKdY2wAuZLyIP9bntaWg652yJG QftiHeE7r0ChgK/izvsbXkAokhXPnJnViL1UKjosC6QsYsND9vLz6FXG20cw8F4L1lst +5OxW1VcEcw1IdGt0wfLh1q2kPUphwUALjge+RwxvmZTKTgcnb3Brw9D/p6+Ga/A8QvE IHRrVwDuTGGHt/8rQ9F8ilAWAkL1kAnNu7oFtUpZyRzGXM6OIdSVi9eBDbFeAorOt2zF m72Q== X-Gm-Message-State: AOJu0Yw10y+zrOB6xQYXa95DFK7qUIuRzn9PBu02W9QmNlKawQU1EoGP zuH3KmbSB/VTe6hXiguJ1Lzh2EVjgZ9PkCrJ9pD3GG5iXWSmAPRDVkRsFAfecue5JID5TxHYDoT p6zcmAclivQXe2yQWwA8DNe0vQZxpiRxcBRRv+/a6Uu28E37rmsyc X-Received: by 2002:a05:6122:98c:b0:4d4:1fe2:c398 with SMTP id 71dfb90a1353d-4e2184ed6ccmr2143793e0c.2.1716382824128; Wed, 22 May 2024 06:00:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCe/aU1oPIwIFKjWlf5lvIs22kFaxCTQJBsbdFexjFF8hf3Z1rqvN441qcZ/IKqooX+EyKDg== X-Received: by 2002:a05:6122:98c:b0:4d4:1fe2:c398 with SMTP id 71dfb90a1353d-4e2184ed6ccmr2143301e0c.2.1716382819118; Wed, 22 May 2024 06:00:19 -0700 (PDT) Received: from [192.168.0.4] (ip-109-43-179-90.web.vodafone.de. [109.43.179.90]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6a15f1797b9sm135219226d6.15.2024.05.22.06.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 06:00:18 -0700 (PDT) Message-ID: <9da29550-950c-4184-94d4-f3f9461a39ad@redhat.com> Date: Wed, 22 May 2024 15:00:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script To: Fabiano Rosas , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Juan Quintela Cc: qemu-devel@nongnu.org, Eric Blake , Leonardo Bras , Vladimir Sementsov-Ogievskiy , Markus Armbruster , Peter Xu , Paolo Bonzini , Fam Zheng , Stefan Hajnoczi , Li Zhijian , John Snow , qemu-block@nongnu.org, Cleber Rosa , Laurent Vivier , Richard Henderson References: <20231017083003.15951-1-quintela@redhat.com> <20231017083003.15951-11-quintela@redhat.com> <87wmnnic86.fsf@draig.linaro.org> <87bk4zjpt2.fsf@suse.de> <3d437c79-89c0-4268-941f-0f97eb6d05b2@redhat.com> <8734qahv0x.fsf@suse.de> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <8734qahv0x.fsf@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 22/05/2024 14.48, Fabiano Rosas wrote: > Thomas Huth writes: > >> On 21/05/2024 14.46, Fabiano Rosas wrote: >>> Alex Bennée writes: >>> >>>> Juan Quintela writes: >>>> >>>>> From: Fabiano Rosas >>>>> >>>>> Add a smoke test that migrates to a file and gives it to the >>>>> script. It should catch the most annoying errors such as changes in >>>>> the ram flags. >>>>> >>>>> After code has been merged it becomes way harder to figure out what is >>>>> causing the script to fail, the person making the change is the most >>>>> likely to know right away what the problem is. >>>>> >>>>> Signed-off-by: Fabiano Rosas >>>>> Acked-by: Thomas Huth >>>>> Reviewed-by: Juan Quintela >>>>> Signed-off-by: Juan Quintela >>>>> Message-ID: <20231009184326.15777-7-farosas@suse.de> >>>> >>>> I bisected the failures I'm seeing on s390x to the introduction of this >>>> script. I don't know if its simply a timeout on a relatively slow VM: >>> >>> What's the range of your bisect? That test has been disabled and then >>> reenabled on s390x. It could be tripping the bisect. >>> >>> 04131e0009 ("tests/qtest/migration-test: Disable the analyze-migration.py test on s390x") >>> 81c2c9dd5d ("tests/qtest/migration-test: Fix analyze-migration.py for s390x") >>> >>> I don't think that test itself could be timing out. It's a very simple >>> test. It runs a migration and then uses the output to validate the >>> script. >> >> Agreed, the analyze-migration.py is unlikely to be the issue - especially >> since it seems to have been disabled again in commit 6f0771de903b ... >> Fabiano, why did you disable it here again? The reason is not mentioned in >> the commit description. > > Your patch 81c2c9dd5d was merged between my v1 and v2 on the list and I > didn't notice so I messed up the rebase. I'll send a patch soon to fix > that. Thanks, but I already sent a patch earlier today that should fix the issue: https://lore.kernel.org/qemu-devel/20240522091255.417263-1-thuth@redhat.com/T/#u Thomas