From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5] target/arm: generate a custom MIDR for -cpu max
Date: Fri, 26 Jul 2019 08:12:44 -0700 [thread overview]
Message-ID: <9dc175a9-3617-3bb3-a03a-3def2ebda02c@linaro.org> (raw)
In-Reply-To: <20190726113950.7499-1-alex.bennee@linaro.org>
On 7/26/19 4:39 AM, Alex Bennée wrote:
> While most features are now detected by probing the ID_* registers
> kernels can (and do) use MIDR_EL1 for working out of they have to
> apply errata. This can trip up warnings in the kernel as it tries to
> work out if it should apply workarounds to features that don't
> actually exist in the reported CPU type.
>
> Avoid this problem by synthesising our own MIDR value.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> ---
> v2
> - don't leak QEMU version into ID reg
> v3
> - move comment into one block
> - explicit setting of more fields
> v4
> - minor reword of comment
> v5
> - VARIANT->PARTNUM and extra words
> ---
> target/arm/cpu.h | 6 ++++++
> target/arm/cpu64.c | 19 +++++++++++++++++++
> 2 files changed, 25 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-07-26 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 11:39 [Qemu-devel] [PATCH v5] target/arm: generate a custom MIDR for -cpu max Alex Bennée
2019-07-26 11:52 ` no-reply
2019-07-26 15:12 ` Richard Henderson [this message]
2019-07-29 12:44 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dc175a9-3617-3bb3-a03a-3def2ebda02c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).