From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] meson: fix qxl module build
Date: Fri, 4 Sep 2020 14:24:45 +0200 [thread overview]
Message-ID: <9de758ed-ae9d-40e6-8ad5-aaf102bc5013@redhat.com> (raw)
In-Reply-To: <20200904121412.lgrm7mlri664jz4n@sirius.home.kraxel.org>
On 04/09/20 14:14, Gerd Hoffmann wrote:
> Hi,
>
>>>> - qxl_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c', 'qxl-render.c'))
>>>> + qxl_ss.add(files('qxl.c', 'qxl-logger.c', 'qxl-render.c'))
>
>> You have found why it's got that "when:". :)
>
>> - module_ss = module_ss.apply(config_host, strict: false)
>> + module_ss = module_ss.apply(config_all, strict: false)
>
> Ah. That nicely explains why the "when:" didn't work in the
> first place.
>
>> etc. This would work also for the CONFIG_VIRTIO_GPU changes.
>
> Yes, virtio-gpu modules are next on the list ;)
Great, feel free to pick the patch up, no need for attribution or anything.
Paolo
prev parent reply other threads:[~2020-09-04 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 6:46 [PATCH] meson: fix qxl module build Gerd Hoffmann
2020-08-27 10:45 ` Marc-André Lureau
2020-09-04 8:12 ` Gerd Hoffmann
2020-09-04 9:02 ` Paolo Bonzini
2020-09-04 12:14 ` Gerd Hoffmann
2020-09-04 12:24 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9de758ed-ae9d-40e6-8ad5-aaf102bc5013@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).