From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Cc: Sven Schnelle <svens@stackframe.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v3 7/8] hw/display/artist: Fix artist screen resolution
Date: Wed, 2 Sep 2020 13:45:18 -0700 [thread overview]
Message-ID: <9dea1e42-6a0d-37d0-07c8-c02f1fa0e2b3@linaro.org> (raw)
In-Reply-To: <20200902193456.29844-8-deller@gmx.de>
On 9/2/20 12:34 PM, Helge Deller wrote:
> Artist screen size is limited to 2048 x 2048 pixels and x/y coordination
> addressing needs to be done by OS via an uint32 value which is based on
> a 2048 byte line length, independend of the real screen size.
>
> Since HP-UX seems to ideally need at least 640 pixels in width, this
> patch ensures that the screen size stays between 640x480 and 2048x2048
> pixels and fixes some pixel glitches were visible before on STI text
> consoles due to the 2048 line length limitation.
>
> Cc: Sven Schnelle <svens@stackframe.org>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> hw/display/artist.c | 37 +++++++++++++++++++++++--------------
> 1 file changed, 23 insertions(+), 14 deletions(-)
You did nothing to address my comments here.
r~
next prev parent reply other threads:[~2020-09-02 20:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 19:34 [PATCH v3 0/8] hppa: power button support, artist graphics fixes, firmware fixes, Helge Deller
2020-09-02 19:34 ` [PATCH v3 1/8] seabios-hppa: Update SeaBIOS to hppa-qemu-5.2-2 tag Helge Deller
2020-09-02 19:34 ` [PATCH v3 2/8] hw/hppa: Make number of TLB and BTLB entries configurable Helge Deller
2020-09-02 19:34 ` [PATCH v3 3/8] hw/hppa: Store boot device in fw_cfg section Helge Deller
2020-09-02 19:34 ` [PATCH v3 4/8] hw/hppa: Change fw_cfg port address Helge Deller
2020-09-02 20:42 ` Richard Henderson
2020-09-02 19:34 ` [PATCH v3 5/8] hw/hppa: Tell SeaBIOS port address of fw_cfg Helge Deller
2020-09-02 20:43 ` Richard Henderson
2020-09-02 19:34 ` [PATCH v3 6/8] hw/hppa: Add power button emulation Helge Deller
2020-09-02 20:44 ` Richard Henderson
2020-09-02 19:34 ` [PATCH v3 7/8] hw/display/artist: Fix artist screen resolution Helge Deller
2020-09-02 20:45 ` Richard Henderson [this message]
2020-09-02 19:34 ` [PATCH v3 8/8] target/hppa: Fix boot with old Linux installation CDs Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dea1e42-6a0d-37d0-07c8-c02f1fa0e2b3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).