From: Eric Blake <eblake@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, crosthwaite.peter@gmail.com, famz@redhat.com,
sagark@eecs.berkeley.edu, kchamart@redhat.com,
kbastian@mail.uni-paderborn.de, riku.voipio@iki.fi,
laurent@vivier.eu, armbru@redhat.com, mjc@sifive.com,
palmer@sifive.com, kraxel@redhat.com, dgibson@redhat.com,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration
Date: Wed, 25 Apr 2018 09:37:23 -0500 [thread overview]
Message-ID: <9dfd1330-64b9-fb7d-78f9-7c058731f022@redhat.com> (raw)
In-Reply-To: <9ffb6634-3480-4ad8-1c9b-e1caa8425628@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
On 04/25/2018 07:26 AM, Laszlo Ersek wrote:
> On 04/25/18 00:03, no-reply@patchew.org wrote:
>> Hi,
>>
>> This series failed docker-mingw@fedora build test. Please find the testing commands and
>> their output below. If you have Docker installed, you can probably reproduce it
>> locally.
>
> [snip]
>
>> qapi/qapi-types-misc.h:654:20: error: expected identifier or '(' before numeric constant
>> CpuInfoX86 i386;
>> ^
> Wow, is "i386" a macro on mingw, one that expands to a number? That is
> incredibly st...range.
>
> I do need this enum constant to be "i386" in the QAPI schema, because
> that's what TARGET_NAME will map to.
>
> Can I let the generator use the "q_" prefix here somehow?
>
> Alright, I'll add "i386" to "polluted_words" in "scripts/qapi/common.py".
>
> Sigh, what else is there already... I see Eric's commit 86ae191163d4 :(
Yep, that's the right fix for working around header pollution.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
prev parent reply other threads:[~2018-04-25 14:37 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 21:45 [Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration Laszlo Ersek
2018-04-24 21:45 ` [Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast Laszlo Ersek
2018-04-24 22:30 ` Eric Blake
2018-04-25 12:30 ` Laszlo Ersek
2018-04-25 6:39 ` Markus Armbruster
2018-04-25 12:30 ` Laszlo Ersek
2018-04-25 7:28 ` Cornelia Huck
2018-04-24 21:45 ` [Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch " Laszlo Ersek
2018-04-24 22:32 ` Eric Blake
2018-04-25 12:32 ` Laszlo Ersek
2018-04-25 6:44 ` Markus Armbruster
2018-04-25 7:48 ` Cornelia Huck
2018-04-25 12:38 ` Viktor VM Mihajlovski
2018-04-25 12:43 ` Laszlo Ersek
2018-04-24 21:45 ` [Qemu-devel] [PATCH 3/6] qapi: add SysEmuTarget to "common.json" Laszlo Ersek
2018-04-24 23:11 ` Eric Blake
2018-04-25 12:54 ` Daniel P. Berrangé
2018-04-25 19:05 ` Laszlo Ersek
2018-04-25 19:08 ` Eric Blake
2018-04-25 22:57 ` Laszlo Ersek
2018-04-24 21:45 ` [Qemu-devel] [PATCH 4/6] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget Laszlo Ersek
2018-04-25 6:48 ` Markus Armbruster
2018-04-25 12:58 ` Laszlo Ersek
2018-04-24 21:45 ` [Qemu-devel] [PATCH 5/6] qapi: extract CpuInfoCommon to mitigate schema duplication Laszlo Ersek
2018-04-25 7:06 ` Markus Armbruster
2018-04-25 13:20 ` Laszlo Ersek
2018-04-25 17:12 ` Markus Armbruster
2018-04-25 19:12 ` Eric Blake
2018-04-25 22:56 ` Laszlo Ersek
2018-04-26 6:19 ` Markus Armbruster
2018-04-24 21:45 ` [Qemu-devel] [PATCH 6/6] qapi: discriminate CpuInfo[Fast] on SysEmuTarget, not CpuInfoArch Laszlo Ersek
2018-04-25 7:33 ` Markus Armbruster
2018-04-25 13:47 ` Laszlo Ersek
2018-04-26 6:26 ` Markus Armbruster
2018-04-26 9:18 ` Laszlo Ersek
2018-04-26 11:57 ` Markus Armbruster
2018-04-26 13:33 ` Laszlo Ersek
2018-04-26 14:34 ` Markus Armbruster
2018-04-26 14:48 ` Eric Blake
2018-04-26 15:51 ` Markus Armbruster
2018-04-26 16:30 ` Laszlo Ersek
2018-04-27 6:53 ` Markus Armbruster
2018-04-27 13:46 ` Eric Blake
2018-04-24 22:03 ` [Qemu-devel] [PATCH 0/6] qapi: introduce the SysEmuTarget enumeration no-reply
2018-04-25 12:26 ` Laszlo Ersek
2018-04-25 14:37 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dfd1330-64b9-fb7d-78f9-7c058731f022@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgibson@redhat.com \
--cc=famz@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kchamart@redhat.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=lersek@redhat.com \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).