qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Kamil Szczęk" <kamil@szczek.dev>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] hw/i386/pc: Add a description for the i8042 property
Date: Tue, 13 Aug 2024 13:24:35 +0200	[thread overview]
Message-ID: <9e09f20d-1ab0-44bd-9f0e-71d29fb90191@redhat.com> (raw)
In-Reply-To: <15fhXFY6x78KW8P5gw0eKTW8kc17zejrJFxqnOyoBy6vw4W9rCmgDhoxssWosWFs_dbFtfsyjn9wpPrV3x8Nlzhy8mTJSEnXCr4qyHAhXSw=@szczek.dev>

On 8/12/24 19:23, Kamil Szczęk wrote:
> While working on exposing the i8042 property in libvirt I noticed that
> the property is missing a description. This adds a simple description
> so that QEMU users don't have to dig in the source code to figure out
> what this option does.
> 
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>

Queued, thanks.

Paolo

> ---
>   hw/i386/pc.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index c74931d577..defbc33125 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1807,6 +1807,8 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>   
>       object_class_property_add_bool(oc, PC_MACHINE_I8042,
>           pc_machine_get_i8042, pc_machine_set_i8042);
> +    object_class_property_set_description(oc, PC_MACHINE_I8042,
> +        "Enable/disable Intel 8042 PS/2 controller emulation");
>   
>       object_class_property_add_bool(oc, "default-bus-bypass-iommu",
>           pc_machine_get_default_bus_bypass_iommu,



      parent reply	other threads:[~2024-08-13 11:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 17:23 [PATCH] hw/i386/pc: Add a description for the i8042 property Kamil Szczęk
2024-08-13  8:37 ` Philippe Mathieu-Daudé
2024-08-13  9:32 ` Zhao Liu
2024-08-13 11:24 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e09f20d-1ab0-44bd-9f0e-71d29fb90191@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kamil@szczek.dev \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).