From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642A7C43603 for ; Fri, 6 Dec 2019 14:11:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A5C820707 for ; Fri, 6 Dec 2019 14:11:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gNqLkaZR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A5C820707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idEKj-00056b-LT for qemu-devel@archiver.kernel.org; Fri, 06 Dec 2019 09:11:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51534) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idEGc-0001LH-P2 for qemu-devel@nongnu.org; Fri, 06 Dec 2019 09:07:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idEGb-0007eS-91 for qemu-devel@nongnu.org; Fri, 06 Dec 2019 09:07:34 -0500 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]:33800) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1idEGa-0007Qh-L9 for qemu-devel@nongnu.org; Fri, 06 Dec 2019 09:07:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Mime-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lNGlgqxAiiv13n2OVehD7agKZsyMMGS2LRYC5Jl0Zmc=; b=gNqLkaZRanqXpTc4VisOxk5H8 mUaJk1QWTE5qm3mttsigSF2TuQlAqhBMgur0N+CrICy19rCd43nLQx9h2GhCh3mVASjXhZnfl4cJC TF6RwD6fcaUuim2cFlJQzg+Dz3Up87OIAu1+p/J2fqqc1FdxjhDmmcMHJAAS9KyN+M5ipyBOtRxzQ bgqTQ0RFCrOIn51PK4iotFoLCSPfc1HUetSG6flglCNE4p925M/b8u1HAN8zCYXp8gAgEHxMNtNzH dt4vIuCkAAnN9jZP7hy/wbaS18WrGNHi1BHYUqWsvv3M6AOQipKHyAGUr6Sij005+G384amfzo0HM CTyUPg2eA==; Received: from [54.239.6.185] (helo=u0c626add9cce5a.ant.amazon.com) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1id9Pu-00059V-Mv; Fri, 06 Dec 2019 08:56:51 +0000 Message-ID: <9e0aba878c29bdda0a8badee3919bc0a46ca0604.camel@kernel.org> Subject: Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer From: Amit Shah To: Pan Nengyuan , mst@redhat.com Date: Fri, 06 Dec 2019 09:56:47 +0100 In-Reply-To: <32796046-ef9b-6157-3bd0-23eef4d4950b@huawei.com> References: <1575444716-17632-1-git-send-email-pannengyuan@huawei.com> <1eaf11e84a6c1cbfbacebe2ae4361925142c1ab6.camel@kernel.org> <32796046-ef9b-6157-3bd0-23eef4d4950b@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:7c80:54:e::133 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liyiting@huawei.com, kuhn.chenqun@huawei.com, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 2019-12-06 at 10:17 +0800, Pan Nengyuan wrote: > On 2019/12/6 0:45, Amit Shah wrote: > > On Wed, 2019-12-04 at 15:31 +0800, pannengyuan@huawei.com wrote: > > > From: Pan Nengyuan > > > > Shouldn't this be From: mst? > > > > I didn't find a ref to the original patch to confirm if you had to > > adapt it in any way, though. > > > > Here is the original > patch:　 > https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00402.html > > I just change one line(set used_elems to NULL). In next version, I > will > change function name from virtio_delete_queue to virtio_queue_cleanup > (It's too similar between "virtio_del_queue" and > "virtio_delete_queue"): > https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00877.html > . > > According to these, should I change it in next version? Sure, please change it. Please ensure 'From:' is Michael, but in the sign-off area, you can mention how you changed the original patch, e.g. see the "[PMM: ...]" in https://lore.kernel.org/qemu-devel/20191126141239.8219-5-peter.maydell@linaro.org/ Also, please CC me on the entire series. Thanks,