From: "Wu, Fei" <fei2.wu@intel.com>
To: Conor Dooley <conor@kernel.org>
Cc: <pbonzini@redhat.com>, <palmer@dabbelt.com>,
<alistair.francis@wdc.com>, <bin.meng@windriver.com>,
<liwei1518@gmail.com>, <dbarboza@ventanamicro.com>,
<zhiwei_liu@linux.alibaba.com>, <qemu-devel@nongnu.org>,
<qemu-riscv@nongnu.org>, <andrei.warkentin@intel.com>,
<shaolin.xie@alibaba-inc.com>, <ved@rivosinc.com>,
<sunilvl@ventanamicro.com>, <haibo1.xu@intel.com>,
<evan.chai@intel.com>, <yin.wang@intel.com>,
<tech-server-platform@lists.riscv.org>,
<tech-server-soc@lists.riscv.org>
Subject: Re: [RFC 1/2] hw/riscv: Add server platform reference machine
Date: Wed, 6 Mar 2024 10:41:14 +0800 [thread overview]
Message-ID: <9e1b19eb-2775-4950-ad60-fbf7d92a6ac6@intel.com> (raw)
In-Reply-To: <20240306-peddling-superglue-fce995d0be84@spud>
Hi Conor,
On 3/6/2024 8:27 AM, Conor Dooley wrote:
> On Mon, Mar 04, 2024 at 06:25:39PM +0800, Fei Wu wrote:
>
>> + name = riscv_isa_string(cpu_ptr);
>> + qemu_fdt_setprop_string(ms->fdt, cpu_name, "riscv,isa", name);
>> + g_free(name);
>
> Please use riscv_isa_write_fdt() here so that you populate more than the
> deprecated property here please.
>
Sure, I saw it's been done in virt.c recently, I will catch up all the
improvements from virt.c to this board.
Thanks,
Fei.
> Thanks,
> Conor.
next prev parent reply other threads:[~2024-03-06 2:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 10:25 [RFC 0/2] Add RISC-V Server Platform Reference Board Fei Wu
2024-03-04 10:25 ` [RFC 1/2] hw/riscv: Add server platform reference machine Fei Wu
2024-03-04 19:35 ` Daniel Henrique Barboza
2024-03-05 5:56 ` Wu, Fei
2024-03-05 9:15 ` Daniel Henrique Barboza
2024-03-06 0:19 ` Alistair Francis
2024-03-06 12:55 ` Wu, Fei
2024-03-06 19:13 ` Atish Kumar Patra
2024-03-07 0:48 ` Alistair Francis
2024-03-07 6:26 ` Wu, Fei
2024-03-08 9:20 ` Andrew Jones
2024-03-11 11:55 ` [RISC-V][tech-server-platform] " Wu, Fei
2024-03-11 14:38 ` [RISC-V][tech-server-soc] " Andrew Jones
2024-03-12 0:19 ` Atish Kumar Patra
2024-03-06 0:27 ` Conor Dooley
2024-03-06 2:41 ` Wu, Fei [this message]
2024-03-04 10:25 ` [RFC 2/2] target/riscv: Add server platform reference cpu Fei Wu
2024-03-04 19:43 ` Daniel Henrique Barboza
2024-03-05 5:58 ` [RISC-V][tech-server-soc] " Wu, Fei
2024-03-06 13:26 ` Wu, Fei
2024-03-07 7:36 ` Wu, Fei
2024-03-07 12:17 ` [RISC-V][tech-server-platform] " Heinrich Schuchardt
2024-03-07 19:27 ` Daniel Henrique Barboza
2024-03-07 19:15 ` Daniel Henrique Barboza
2024-03-12 12:33 ` Wu, Fei
2024-03-12 12:52 ` Daniel Henrique Barboza
2024-03-04 11:02 ` [RISC-V][tech-server-platform] [RFC 0/2] Add RISC-V Server Platform Reference Board Heinrich Schuchardt
2024-03-04 11:42 ` Chai, Evan
2024-03-07 22:15 ` Marcin Juszkiewicz
2024-03-12 8:59 ` Wu, Fei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e1b19eb-2775-4950-ad60-fbf7d92a6ac6@intel.com \
--to=fei2.wu@intel.com \
--cc=alistair.francis@wdc.com \
--cc=andrei.warkentin@intel.com \
--cc=bin.meng@windriver.com \
--cc=conor@kernel.org \
--cc=dbarboza@ventanamicro.com \
--cc=evan.chai@intel.com \
--cc=haibo1.xu@intel.com \
--cc=liwei1518@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=shaolin.xie@alibaba-inc.com \
--cc=sunilvl@ventanamicro.com \
--cc=tech-server-platform@lists.riscv.org \
--cc=tech-server-soc@lists.riscv.org \
--cc=ved@rivosinc.com \
--cc=yin.wang@intel.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).