From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Filip Bozuta <Filip.Bozuta@syrmia.com>
Subject: Re: [PATCH v2 1/2] linux-user: fix the errno value in print_syscall_err()
Date: Wed, 8 Jul 2020 08:49:15 -0700 [thread overview]
Message-ID: <9e272f2b-69f3-40c0-47d3-aaf32c749cc0@linaro.org> (raw)
In-Reply-To: <20200708152435.706070-2-laurent@vivier.eu>
On 7/8/20 8:24 AM, Laurent Vivier wrote:
> errno of the target is returned as a negative value by the syscall,
> not in the host errno variable.
>
> The emulation of the target syscall can return an error while the
> host doesn't set an errno value. Target errnos and host errnos can
> also differ in some cases.
>
> Fixes: c84be71f6854 ("linux-user: Extend strace support to enable argument printing after syscall execution")
> Cc: Filip.Bozuta@syrmia.com
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> linux-user/strace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-07-08 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 15:24 [PATCH v2 0/2] linux-user: fix print_syscall_err() Laurent Vivier
2020-07-08 15:24 ` [PATCH v2 1/2] linux-user: fix the errno value in print_syscall_err() Laurent Vivier
2020-07-08 15:49 ` Richard Henderson [this message]
2020-07-08 16:47 ` Philippe Mathieu-Daudé
2020-07-10 13:48 ` Filip Bozuta
2020-07-13 19:29 ` Laurent Vivier
2020-07-08 15:24 ` [PATCH v2 2/2] linux-user: fix print_syscall_err() when syscall returned value is negative Laurent Vivier
2020-07-08 15:52 ` Richard Henderson
2020-07-08 16:13 ` Laurent Vivier
2020-07-13 19:34 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e272f2b-69f3-40c0-47d3-aaf32c749cc0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Filip.Bozuta@syrmia.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).