From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3944FCE8E73 for ; Thu, 24 Oct 2024 13:12:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3xdO-0007TN-AH; Thu, 24 Oct 2024 09:12:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3xdM-0007Sh-HR for qemu-devel@nongnu.org; Thu, 24 Oct 2024 09:12:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3xdK-0005dF-M5 for qemu-devel@nongnu.org; Thu, 24 Oct 2024 09:12:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729775529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RN8Jcy9yKG+cZOUgptnwvJ3+f23Fpd6NB4PQrz4NV38=; b=iOfE/1x9fjGbFhAtBrwDRfjwMNHTs/lKvo/+iioEnFXXFYVawmUMnjuCF1/5y6HfHS/FCv KiUGrzE2FS8FBnFrQZH832dIJIexV2nhma0E8a8IJydD09YjzVVjmX1ziVlPmdLce8MAVX jwzfRQjsdQ8UQJK+IT2YGSW6r2bn3PQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-tk1dG40YNpiY7jveawLCpw-1; Thu, 24 Oct 2024 09:12:08 -0400 X-MC-Unique: tk1dG40YNpiY7jveawLCpw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4316655b2f1so6503305e9.0 for ; Thu, 24 Oct 2024 06:12:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729775527; x=1730380327; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RN8Jcy9yKG+cZOUgptnwvJ3+f23Fpd6NB4PQrz4NV38=; b=eczlBlL5rIjU1+nVz53gLDdSCGBb1zvPSvYVj1dOa7QF8RC+BqZ2QWFx7Xupj3/w9x JEfwbPlJhjkjmThEf1cshA1C2dkUEUlVYISdrsZ5xnRJJcnGab3RrSPuq+1xBPrefeUf eG6Av+dItfgCUo5TD8ZYvKtZc7Pi/FVA0fEx1VLLIlrKyH5Nzs2eh2oXcNEhLz1rDtFR PXboJZst/VrT84eSLBqydBnnQf+tHIRpgZRxg9sji/Pk/9WQROdiKBZ1zo+h2KECNGXq CMtIDudV3yzkaRzIMFK1dvTBOdvdiyTNu1/5Dv/eH4q6D1HJAk7zkCwNO0W1Me5s/51R kfUQ== X-Forwarded-Encrypted: i=1; AJvYcCWeiCjOZnGx9wguvrGlFuvbXKLho4pHeXnwV8bPplCwOY/Xod2LyRA8qn4GBPG+gcradStFZF6ldnCn@nongnu.org X-Gm-Message-State: AOJu0YzXWNHabs3xfUOURA+K2kZBOpPTiuHoIY42Akj3vqV3qDcdcS2r iQEfPNYiwCsSu4dEyganwYsJIKUZU9JWctkv2sYJx+U7SFdvxQHMVcg4rGuztgTiBFrOnX0GlVK P2H+y+AeKZ9bQzoHEUjlS+lPJQJ9UPZ8S8KTwgaF79sEs3FuFIY7m X-Received: by 2002:a05:600c:1c01:b0:431:58b3:affa with SMTP id 5b1f17b1804b1-4318413e709mr49540905e9.9.1729775527203; Thu, 24 Oct 2024 06:12:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEiOqzL6ed+rzEr+JZx3ikKSW2MRVlv0ESyAUxHs0A6AYMxI1teGo4s5RApstER3UkQGRZu2Q== X-Received: by 2002:a05:600c:1c01:b0:431:58b3:affa with SMTP id 5b1f17b1804b1-4318413e709mr49540685e9.9.1729775526831; Thu, 24 Oct 2024 06:12:06 -0700 (PDT) Received: from ?IPV6:2a01:e0a:165:d60:bbdd:3c5e:7d8b:3f72? ([2a01:e0a:165:d60:bbdd:3c5e:7d8b:3f72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4318b567fe8sm17389675e9.28.2024.10.24.06.12.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2024 06:12:06 -0700 (PDT) Message-ID: <9e408f6e-d86f-45e7-9940-b9a4a1ccee47@redhat.com> Date: Thu, 24 Oct 2024 15:12:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hw/s390x: Re-enable the pci-bridge device on s390x To: Thomas Huth , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman Cc: qemu-s390x@nongnu.org, Boris Fiuczynski References: <20241024130405.62134-1-thuth@redhat.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: <20241024130405.62134-1-thuth@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.263, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.697, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/24/24 15:04, Thomas Huth wrote: > Commit e779e5c05a ("hw/pci-bridge: Add a Kconfig switch for the > normal PCI bridge") added a config switch for the pci-bridge, so > that the device is not included in the s390x target anymore (since > the pci-bridge is not really useful on s390x). > > However, it seems like libvirt is still adding pci-bridge devices > automatically to the guests' XML definitions (when adding a PCI > device to a non-zero PCI bus), so these guests are now broken due > to the missing pci-bridge in the QEMU binary. > > To avoid disruption of the users, let's re-enable the pci-bridge > device on s390x for the time being. We could maybe disable it later > again if libvirt does not add the pci-bridge device automatically > to the guests anymore in the future. > > Signed-off-by: Thomas Huth Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/s390x/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig > index 3bbf4ae56e..82afdaa9dc 100644 > --- a/hw/s390x/Kconfig > +++ b/hw/s390x/Kconfig > @@ -7,6 +7,7 @@ config S390_CCW_VIRTIO > imply VFIO_AP > imply VFIO_CCW > imply WDT_DIAG288 > + imply PCI_BRIDGE > imply PCIE_DEVICES > imply IOMMUFD > select PCI_EXPRESS