From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 081FFC2D0A3 for ; Tue, 10 Nov 2020 03:37:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BEA321D91 for ; Tue, 10 Nov 2020 03:37:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rmzndc4f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BEA321D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcKTU-0006hv-2k for qemu-devel@archiver.kernel.org; Mon, 09 Nov 2020 22:37:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcKSf-00063f-Rs for qemu-devel@nongnu.org; Mon, 09 Nov 2020 22:36:49 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:37163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcKSc-0006bc-FQ for qemu-devel@nongnu.org; Mon, 09 Nov 2020 22:36:49 -0500 Received: by mail-pl1-x643.google.com with SMTP id b12so5782434plr.4 for ; Mon, 09 Nov 2020 19:36:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=w1AtoijchZskA1WbSwDurrxO3GME61Mrm83kGKPg3zU=; b=rmzndc4fpadq8U0FBn/x/zCZUZlnl6zauxkglTaocmN4rfnA4hvP+2Amo7hxxOQ6JN PHKsf1mLNX2Z79tIVOpOEjzozOmQHWTXHN9U0bcNMy1ce/yyKNDpGqr8LnDMRHTyXHYs FTX+ZUIQD1B2qXyOA8lvhr81k5KE/bsb8dGRj8waMRDrdXOntbS5yk8jLOfB3UxMomHu 5I+hkiYV1HcfV580YQfGa99P60DvnW2u3W7xPIOH7C3ajUoTEmefknUYLjzs3+UvcKxO oozhrpYeqLBQB3NuoicMTDJ0zcjKi32UjtaScWgI8FTMmSx13xgNKfCgptc/xATi5T6R /AEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w1AtoijchZskA1WbSwDurrxO3GME61Mrm83kGKPg3zU=; b=FHRstdklC5P9VPuzJLiEYQw+ePybyDAjmgPkziPN5VsZnrUTnfB63w7MmMMyOcjdaz c8MD6OpoZAXnlSNx6zTlvPKBR5eZXunAW9oGt4rgZ9Vkmvl73ZvB8FG6ztAzeURxxeWS A4/lDd7Is9Xw4yzMvTA9X8HYhAcq3bDQD6JHIyAK1ZggEFViwsV9eTTM2tssZYmrDaZ8 bYbe95TyqiGYTHTh4s2Z8myWsfiLCSzGS2Qr9N0GJ6RymYO7Ej517y6H2VssoipExoiq JiKYjqyBaJwcsvFtOh67d5wfdeA/uPTutNh6Ga/56QSCZaiwsUhELroElOZiTa8XdMGt luVg== X-Gm-Message-State: AOAM532ChIacP0VSmh16qu7EvvDJOmVWBuf6uVdqFblhfDdErHcYDUA0 14+DSTd64zGP0JHEzGL1zkclr3xpjxPJuw== X-Google-Smtp-Source: ABdhPJxSroMdMGaP0AfYzNYDq4FX25/mOThFqvuh2F1UVFLVxWIGxy6fLgVFbKTHX+M2Pe2Jb9MANw== X-Received: by 2002:a17:902:778d:b029:d6:489c:67ee with SMTP id o13-20020a170902778db02900d6489c67eemr15367224pll.52.1604979404700; Mon, 09 Nov 2020 19:36:44 -0800 (PST) Received: from [192.168.3.43] (068-185-011-182.biz.spectrum.com. [68.185.11.182]) by smtp.gmail.com with ESMTPSA id gk22sm955718pjb.39.2020.11.09.19.36.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2020 19:36:43 -0800 (PST) Subject: Re: [PATCH] target/arm/translate-neon.c: Handle VTBL UNDEF case before VFP access check To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20201109145324.2859-1-peter.maydell@linaro.org> From: Richard Henderson Message-ID: <9e41e645-1a99-8fd8-60a6-36eb1931dbce@linaro.org> Date: Mon, 9 Nov 2020 19:36:41 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201109145324.2859-1-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::643; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x643.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/9/20 6:53 AM, Peter Maydell wrote: > Checks for UNDEF cases should go before the "is VFP enabled?" access > check, except in special cases. Move a stray UNDEF check in the VTBL > trans function up above the access check. > > Signed-off-by: Peter Maydell > --- > Based-on: 20201105171126.88014-1-richard.henderson@linaro.org > ("target/arm: Fix neon VTBL/VTBX for len > 1") > --- > target/arm/translate-neon.c.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~