From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Seeking QEMU makefile advice
Date: Wed, 13 Feb 2019 15:18:31 +0100 [thread overview]
Message-ID: <9e429792-cbea-c96c-ad48-7f5bdd7ef781@redhat.com> (raw)
In-Reply-To: <871s4chvb2.fsf@dusky.pond.sub.org>
On 13/02/19 10:49, Markus Armbruster wrote:
> * Define QAPI_COMMON_MODULES, QAPI_TARGET_MODULES and QAPI_MODULES in
> Makefile.obj
>
> * Add to util-obj-y in Makefile.obj
>
> * Add to obj-y in Makefile.target
Why can't both be in Makefile.objs, or in qapi/Makefile.objs?
Paolo
> No go, because QAPI_TARGET_MODULES is blank there. To make progress,
> I duplicated its definition there, marked FIXME.
>
> Message-Id: <20190206181725.14337-8-armbru@redhat.com>
> https://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg01652.html
> Diff appended for your convenience.
>
> I've since realized QAPI_TARGET_MODULES is blank there because it only
> gets defined further down, via include $(SRC_PATH)/Makefile.objs.
>
> This leads me to my problem:
>
> * On the one hand, I want to add to obj-y after the include defines
> QAPI_TARGET_MODULES.
>
> * On the other hand, I need to be done with adding to obj-y before the
> all-obj-y := $(obj-y) line.
>
> Can't satisfy both. Any ideas on how to better distribute the work
> between the makefiles?
next prev parent reply other threads:[~2019-02-13 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:49 [Qemu-devel] Seeking QEMU makefile advice Markus Armbruster
2019-02-13 14:18 ` Paolo Bonzini [this message]
2019-02-13 16:15 ` Markus Armbruster
2019-02-13 16:19 ` Paolo Bonzini
2019-02-14 8:30 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e429792-cbea-c96c-ad48-7f5bdd7ef781@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).