From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51729) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1y0O-0005Dx-4W for qemu-devel@nongnu.org; Wed, 02 Nov 2016 12:03:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1y0J-0005QD-90 for qemu-devel@nongnu.org; Wed, 02 Nov 2016 12:03:12 -0400 Received: from mga04.intel.com ([192.55.52.120]:62444) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1y0J-0005Q3-0g for qemu-devel@nongnu.org; Wed, 02 Nov 2016 12:03:07 -0400 References: <1477672540-27952-1-git-send-email-guangrong.xiao@linux.intel.com> <1477672540-27952-5-git-send-email-guangrong.xiao@linux.intel.com> <20161102122142.5e9271e2@nial.brq.redhat.com> From: Xiao Guangrong Message-ID: <9e49eaa4-25da-a958-5676-0b5e701b38e3@linux.intel.com> Date: Wed, 2 Nov 2016 23:55:43 +0800 MIME-Version: 1.0 In-Reply-To: <20161102122142.5e9271e2@nial.brq.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/4] pc: memhp: enable nvdimm device hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org On 11/02/2016 07:21 PM, Igor Mammedov wrote: > On Sat, 29 Oct 2016 00:35:40 +0800 > Xiao Guangrong wrote: > >> _GPE.E04 is dedicated for nvdimm device hotplug >> >> Signed-off-by: Xiao Guangrong >> --- >> docs/specs/acpi_mem_hotplug.txt | 3 +++ >> hw/acpi/memory_hotplug.c | 31 +++++++++++++++++++++++-------- >> hw/i386/acpi-build.c | 7 +++++++ >> hw/i386/pc.c | 12 ++++++++++++ >> hw/mem/nvdimm.c | 4 ---- >> include/hw/acpi/acpi_dev_interface.h | 1 + >> 6 files changed, 46 insertions(+), 12 deletions(-) >> >> diff --git a/docs/specs/acpi_mem_hotplug.txt b/docs/specs/acpi_mem_hotplug.txt >> index 3df3620..cb26dd2 100644 >> --- a/docs/specs/acpi_mem_hotplug.txt >> +++ b/docs/specs/acpi_mem_hotplug.txt >> @@ -4,6 +4,9 @@ QEMU<->ACPI BIOS memory hotplug interface >> ACPI BIOS GPE.3 handler is dedicated for notifying OS about memory hot-add >> and hot-remove events. >> >> +ACPI BIOS GPE.4 handler is dedicated for notifying OS about nvdimm device >> +hot-add and hot-remove events. > that should be part of nvdimm spec Okay. > >> Memory hot-plug interface (IO port 0xa00-0xa17, 1-4 byte access): >> --------------------------------------------------------------- >> 0xa00: >> diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c >> index ec4e64b..70f6451 100644 >> --- a/hw/acpi/memory_hotplug.c >> +++ b/hw/acpi/memory_hotplug.c > so far nvdimm hotplug has nothing do with memory hotplug so revert > all changes you did to this file and put nvdimm hotplug handler > code into hw/acpi/nvdimm.c > > and call it from respective ich9/piix4_pm handlers. Okay.