From: Jagannathan Raman <jag.raman@oracle.com>
To: qemu-devel@nongnu.org
Cc: elena.ufimtseva@oracle.com, fam@euphon.net,
swapnil.ingle@nutanix.com, john.g.johnson@oracle.com,
kraxel@redhat.com, jag.raman@oracle.com, quintela@redhat.com,
mst@redhat.com, armbru@redhat.com, kanth.ghatraju@oracle.com,
felipe@nutanix.com, thuth@redhat.com, ehabkost@redhat.com,
konrad.wilk@oracle.com, dgilbert@redhat.com,
alex.williamson@redhat.com, stefanha@redhat.com,
thanos.makatos@nutanix.com, kwolf@redhat.com,
berrange@redhat.com, mreitz@redhat.com,
ross.lagerwall@citrix.com, marcandre.lureau@gmail.com,
pbonzini@redhat.com
Subject: [PATCH v13 13/19] multi-process: add proxy communication functions
Date: Mon, 14 Dec 2020 00:14:53 -0500 [thread overview]
Message-ID: <9e5d59be618b93f8774edd2f9ed76b8c26de9d18.1607922214.git.jag.raman@oracle.com> (raw)
In-Reply-To: <cover.1607922214.git.jag.raman@oracle.com>
In-Reply-To: <cover.1607922214.git.jag.raman@oracle.com>
From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/hw/remote/mpqemu-link.h | 4 ++++
hw/remote/mpqemu-link.c | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/include/hw/remote/mpqemu-link.h b/include/hw/remote/mpqemu-link.h
index 48c617e..36b540c 100644
--- a/include/hw/remote/mpqemu-link.h
+++ b/include/hw/remote/mpqemu-link.h
@@ -15,6 +15,8 @@
#include "qemu/thread.h"
#include "io/channel.h"
#include "exec/hwaddr.h"
+#include "io/channel-socket.h"
+#include "hw/remote/proxy.h"
#define REMOTE_MAX_FDS 8
@@ -68,6 +70,8 @@ typedef struct {
bool mpqemu_msg_send(MPQemuMsg *msg, QIOChannel *ioc, Error **errp);
bool mpqemu_msg_recv(MPQemuMsg *msg, QIOChannel *ioc, Error **errp);
+uint64_t mpqemu_msg_send_and_await_reply(MPQemuMsg *msg, PCIProxyDev *pdev,
+ Error **errp);
bool mpqemu_msg_valid(MPQemuMsg *msg);
#endif
diff --git a/hw/remote/mpqemu-link.c b/hw/remote/mpqemu-link.c
index 5c9af1d..df35a4d 100644
--- a/hw/remote/mpqemu-link.c
+++ b/hw/remote/mpqemu-link.c
@@ -182,6 +182,40 @@ fail:
return ret;
}
+/*
+ * Send msg and wait for a reply with command code RET_MSG.
+ * Returns the message received of size u64 or UINT64_MAX
+ * on error.
+ * Called from VCPU thread in non-coroutine context.
+ * Used by the Proxy object to communicate to remote processes.
+ */
+uint64_t mpqemu_msg_send_and_await_reply(MPQemuMsg *msg, PCIProxyDev *pdev,
+ Error **errp)
+{
+ ERRP_GUARD();
+ MPQemuMsg msg_reply = {0};
+ uint64_t ret = UINT64_MAX;
+
+ assert(!qemu_in_coroutine());
+
+ QEMU_LOCK_GUARD(&pdev->io_mutex);
+ if (!mpqemu_msg_send(msg, pdev->ioc, errp)) {
+ return ret;
+ }
+
+ if (!mpqemu_msg_recv(&msg_reply, pdev->ioc, errp)) {
+ return ret;
+ }
+
+ if (!mpqemu_msg_valid(&msg_reply)) {
+ error_setg(errp, "ERROR: Invalid reply received for command %d",
+ msg->cmd);
+ return ret;
+ }
+
+ return msg_reply.data.u64;
+}
+
bool mpqemu_msg_valid(MPQemuMsg *msg)
{
if (msg->cmd >= MPQEMU_CMD_MAX && msg->cmd < 0) {
--
1.8.3.1
next prev parent reply other threads:[~2020-12-14 5:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 5:14 [PATCH v13 00/19] Initial support for multi-process Qemu Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 01/19] multi-process: add the concept description to docs/devel/qemu-multiprocess Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 02/19] multi-process: add configure and usage information Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 03/19] memory: alloc RAM from file at offset Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 04/19] multi-process: Add config option for multi-process QEMU Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 05/19] multi-process: setup PCI host bridge for remote device Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 06/19] multi-process: setup a machine object for remote device process Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 07/19] multi-process: add qio channel function to transmit data and fds Jagannathan Raman
2020-12-15 10:49 ` Marc-André Lureau
2020-12-15 20:42 ` Elena Ufimtseva
2020-12-15 21:22 ` Elena Ufimtseva
2020-12-16 10:02 ` Stefan Hajnoczi
2020-12-14 5:14 ` [PATCH v13 08/19] multi-process: define MPQemuMsg format and transmission functions Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 09/19] multi-process: Initialize message handler in remote device Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 10/19] multi-process: Associate fd of a PCIDevice with its object Jagannathan Raman
2020-12-14 21:23 ` Stefan Hajnoczi
2020-12-16 13:43 ` Marc-André Lureau
2020-12-16 17:06 ` Jag Raman
2020-12-16 17:34 ` Marc-André Lureau
2020-12-16 17:39 ` Jag Raman
2020-12-14 5:14 ` [PATCH v13 11/19] multi-process: setup memory manager for remote device Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 12/19] multi-process: introduce proxy object Jagannathan Raman
2020-12-16 13:45 ` Marc-André Lureau
2020-12-14 5:14 ` Jagannathan Raman [this message]
2020-12-14 5:14 ` [PATCH v13 14/19] multi-process: Forward PCI config space acceses to the remote process Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 15/19] multi-process: PCI BAR read/write handling for proxy & remote endpoints Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 16/19] multi-process: Synchronize remote memory Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 17/19] multi-process: create IOHUB object to handle irq Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 18/19] multi-process: Retrieve PCI info from remote process Jagannathan Raman
2020-12-14 5:14 ` [PATCH v13 19/19] multi-process: perform device reset in the " Jagannathan Raman
2020-12-14 21:17 ` [PATCH v13 00/19] Initial support for multi-process Qemu Stefan Hajnoczi
2020-12-14 23:49 ` Jag Raman
2020-12-15 10:45 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e5d59be618b93f8774edd2f9ed76b8c26de9d18.1607922214.git.jag.raman@oracle.com \
--to=jag.raman@oracle.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=felipe@nutanix.com \
--cc=john.g.johnson@oracle.com \
--cc=kanth.ghatraju@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ross.lagerwall@citrix.com \
--cc=stefanha@redhat.com \
--cc=swapnil.ingle@nutanix.com \
--cc=thanos.makatos@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).