Re: [Qemu-devel] [PATCH v2 for-2.13 1/3] net: Remove the deprecated "vlan" parameter

[Thomas Huth <thuth@redhat.com>]

On 06.04.2018 16:17, Paolo Bonzini wrote:
> On 06/04/2018 15:37, Thomas Huth wrote:
>> It's been marked as deprecated since QEMU v2.9.0, so that should have
>> been enough time for everybody to switch to the modern -device + -netdev
>> syntax for connecting guest NICs with host network backends, or to switch
>> to the "hubport" netdev in case hubs are really wanted instead.
> 
> ... or to just drop unnecessary "vlan=0", which is the really common case.
> 
>>
>>  # @NetdevL2TPv3Options:
>>  #
>> -# Connect the VLAN to Ethernet over L2TPv3 Static tunnel
>> +# Configure an Ethernet over L2TPv3 Static tunnel.
>>  #
> 
> Since you are at it, probably remove "Static"?  I don't see the point
> really.

Sure, will do.

>> or the netdev 'nd' (for pluggable\n"
>> "                NICs please use '-device devtype,netdev=nd' instead)\n"
> 
> Maybe remove this if -net is prominently marked deprecated?  And mention
> using -nic instead of "-net nic,netdev=...".

Yes, "-net nic,netdev=..." does indeed not make much sense anymore now
that we've got "-nic". I'll remove it from the documentation in the next
version of the patch.

 Thomas