qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: matheus.ferst@eldorado.org.br, qemu-devel@nongnu.org,
	qemu-ppc@nongnu.org
Cc: thuth@redhat.com, danielhb413@gmail.com, groug@kaod.org,
	philippe.mathieu.daude@gmail.com, clg@kaod.org,
	mrezanin@redhat.com, alex.bennee@linaro.org,
	david@gibson.dropbear.id.au
Subject: Re: [RFC PATCH v2 4/5] tests/tcg/ppc64le: emit bcdsub with .long when needed
Date: Thu, 3 Mar 2022 09:19:35 -1000	[thread overview]
Message-ID: <9e7132f7-0bc7-24c9-09f3-abc32e0871de@linaro.org> (raw)
In-Reply-To: <20220303172041.1915037-5-matheus.ferst@eldorado.org.br>

On 3/3/22 07:20, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst<matheus.ferst@eldorado.org.br>
> 
> Based on GCC docs[1], we use the '-mpower8-vector' flag at config-time
> to detect the toolchain support to the bcdsub instruction. LLVM/Clang
> supports this flag since version 3.6[2], but the instruction and related
> builtins were only added in LLVM 14[3]. In the absence of other means to
> detect this support at config-time, we resort to __has_builtin to
> identify the presence of __builtin_bcdsub at compile-time. If the
> builtin is not available, the instruction is emitted with a ".long".
> 
> [1]https://gcc.gnu.org/onlinedocs/gcc-8.3.0/gcc/PowerPC-AltiVec_002fVSX-Built-in-Functions.html
> [2]https://github.com/llvm/llvm-project/commit/59eb767e11d4ffefb5f55409524e5c8416b2b0db
> [3]https://github.com/llvm/llvm-project/commit/c933c2eb334660c131f4afc9d194fafb0cec0423
> 
> Signed-off-by: Matheus Ferst<matheus.ferst@eldorado.org.br>
> ---
>   tests/tcg/ppc64le/bcdsub.c | 55 +++++++++++++++++++++-----------------
>   1 file changed, 30 insertions(+), 25 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2022-03-03 19:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 17:20 [PATCH v2 0/5] tests/tcg/ppc64le: fix the build of TCG tests with Clang matheus.ferst
2022-03-03 17:20 ` [PATCH v2 1/5] tests/tcg/ppc64le: use inline asm instead of __builtin_mtfsf matheus.ferst
2022-03-03 18:46   ` Richard Henderson
2022-03-03 17:20 ` [PATCH v2 2/5] target/ppc: change xs[n]madd[am]sp to use float64r32_muladd matheus.ferst
2022-03-03 18:49   ` Richard Henderson
2022-03-03 20:53     ` Matheus K. Ferst
2022-03-03 17:20 ` [RFC PATCH v2 3/5] tests/tcg/ppc64le: drop __int128 usage in bcdsub matheus.ferst
2022-03-03 18:57   ` Richard Henderson
2022-03-03 17:20 ` [RFC PATCH v2 4/5] tests/tcg/ppc64le: emit bcdsub with .long when needed matheus.ferst
2022-03-03 19:19   ` Richard Henderson [this message]
2022-03-03 17:20 ` [PATCH v2 5/5] tests/tcg/ppc64le: Use Altivec register names in clobbler list matheus.ferst
2022-03-03 19:30   ` Richard Henderson
2022-03-03 20:53     ` Matheus K. Ferst
2022-03-03 21:05       ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e7132f7-0bc7-24c9-09f3-abc32e0871de@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=matheus.ferst@eldorado.org.br \
    --cc=mrezanin@redhat.com \
    --cc=philippe.mathieu.daude@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).