From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] system/qtest: Include missing 'hw/core/cpu.h' header
Date: Tue, 12 Dec 2023 13:11:35 +0100 [thread overview]
Message-ID: <9e810a60-b390-4c6f-ae02-a2863176bb1b@redhat.com> (raw)
In-Reply-To: <20231212113016.29808-2-philmd@linaro.org>
On 12/12/2023 12.30, Philippe Mathieu-Daudé wrote:
> "hw/core/cpu.h" declares 'first_cpu'. Include it to avoid
> when unrelated headers are refactored:
>
> system/qtest.c:548:33: error: use of undeclared identifier 'first_cpu'
> address_space_write(first_cpu->as, addr, MEMTXATTRS_UNSPECIFIED,
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> system/qtest.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/system/qtest.c b/system/qtest.c
> index 7964f0b248..6da58b3874 100644
> --- a/system/qtest.c
> +++ b/system/qtest.c
> @@ -21,6 +21,7 @@
> #include "exec/tswap.h"
> #include "hw/qdev-core.h"
> #include "hw/irq.h"
> +#include "hw/core/cpu.h"
> #include "qemu/accel.h"
> #include "sysemu/cpu-timers.h"
> #include "qemu/config-file.h"
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-12-12 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 11:30 [PATCH 0/2] system/qtest: Minor include cleanups Philippe Mathieu-Daudé
2023-12-12 11:30 ` [PATCH 1/2] system/qtest: Include missing 'hw/core/cpu.h' header Philippe Mathieu-Daudé
2023-12-12 12:11 ` Thomas Huth [this message]
2023-12-12 11:30 ` [PATCH 2/2] system/qtest: Restrict QTest API to system emulation Philippe Mathieu-Daudé
2023-12-12 13:24 ` Thomas Huth
2023-12-26 15:40 ` [PATCH 0/2] system/qtest: Minor include cleanups Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e810a60-b390-4c6f-ae02-a2863176bb1b@redhat.com \
--to=thuth@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).