qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org
Cc: mreitz@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 8/8] quorum: Inline quorum_fifo_aio_cb()
Date: Tue, 22 Nov 2016 06:51:04 -0600	[thread overview]
Message-ID: <9e8b4985-fc80-802d-ff33-f2ccb36fb2ec@redhat.com> (raw)
In-Reply-To: <w51oa17zx4b.fsf@maestria.local.igalia.com>

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

On 11/22/2016 03:23 AM, Alberto Garcia wrote:
> On Mon 21 Nov 2016 09:08:06 PM CET, Eric Blake <eblake@redhat.com> wrote:
> 
>> Back to my comments earlier in the series - We may want to think about
>> a parallel FIFO mode, where we kick off all reads, but then are
>> prepared to cancel reads on later children once we have a positive
>> answer on an earlier child.
> 
> And what happens if the positive answer comes first from a later child?
> Does COLO rely on the assumption that the first child is always read
> first?

In parallel FIFO mode, it wouldn't matter if the second child has an
answer first, you STILL have to wait for the first child's answer. It's
just that if the first child fails, you have a headstart (or even an
answer already) on the second child, rather than starting the second
child from scratch.  In other words, parallel mode wastes a lot of work
when the first child is successful, but saves time if the first child fails.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      reply	other threads:[~2016-11-22 12:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 17:31 [Qemu-devel] [PATCH 0/8] quorum: Implement .bdrv_co_preadv/pwritev() Kevin Wolf
2016-11-21 17:31 ` [Qemu-devel] [PATCH 1/8] coroutine: Introduce qemu_coroutine_enter_if_inactive() Kevin Wolf
2016-11-21 17:31 ` [Qemu-devel] [PATCH 2/8] quorum: Remove s from quorum_aio_get() arguments Kevin Wolf
2016-11-21 17:31 ` [Qemu-devel] [PATCH 3/8] quorum: Implement .bdrv_co_readv/writev Kevin Wolf
2016-11-21 17:58   ` Eric Blake
2016-11-22 11:32     ` Kevin Wolf
2016-11-22  7:39   ` Alberto Garcia
2016-11-21 17:31 ` [Qemu-devel] [PATCH 4/8] quorum: Do cleanup in caller coroutine Kevin Wolf
2016-11-21 19:03   ` Eric Blake
2016-11-21 17:31 ` [Qemu-devel] [PATCH 5/8] quorum: Inline quorum_aio_cb() Kevin Wolf
2016-11-21 19:21   ` Eric Blake
2016-11-22  7:43   ` Alberto Garcia
2016-11-21 17:31 ` [Qemu-devel] [PATCH 6/8] quorum: Avoid bdrv_aio_writev() for rewrites Kevin Wolf
2016-11-21 19:52   ` Eric Blake
2016-11-22  7:45   ` Alberto Garcia
2016-11-21 17:31 ` [Qemu-devel] [PATCH 7/8] quorum: Implement .bdrv_co_preadv/pwritev() Kevin Wolf
2016-11-21 20:04   ` Eric Blake
2016-11-22 11:45     ` Kevin Wolf
2016-11-22 12:49       ` Eric Blake
2016-11-21 17:31 ` [Qemu-devel] [PATCH 8/8] quorum: Inline quorum_fifo_aio_cb() Kevin Wolf
2016-11-21 20:08   ` Eric Blake
2016-11-22  9:23     ` Alberto Garcia
2016-11-22 12:51       ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e8b4985-fc80-802d-ff33-f2ccb36fb2ec@redhat.com \
    --to=eblake@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).