Re: [PATCH 2/7] pc-bios/s390-ccw: Split virtio-ccw and generic virtio

[Jared Rossi <jrossi@linux.ibm.com>]

Hi Thomas,

Thanks for your comments...

On 10/21/25 5:23 AM, Thomas Huth wrote:
>  Hi Jared!
>
> On 20/10/2025 18.20, jrossi@linux.ibm.com wrote:
>> From: Jared Rossi <jrossi@linux.ibm.com>
>>
>> Separate the CCW specific virtio routines and create generic wrappers 
>> for easier
>> reuse of existing virtio functions with non-CCW devices.
>>
>> Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
>> ---
>>   hw/s390x/ipl.h                   |   5 -
>>   include/hw/s390x/ipl/qipl.h      |   6 +
>>   pc-bios/s390-ccw/iplb.h          |   4 -
>>   pc-bios/s390-ccw/virtio-ccw.h    |  25 ++++
>>   pc-bios/s390-ccw/virtio-scsi.h   |   2 +-
>>   pc-bios/s390-ccw/virtio.h        |  11 +-
>>   pc-bios/s390-ccw/main.c          |  13 +-
>>   pc-bios/s390-ccw/virtio-blkdev.c |  57 +++++---
>>   pc-bios/s390-ccw/virtio-ccw.c    | 240 +++++++++++++++++++++++++++++++
>>   pc-bios/s390-ccw/virtio-net.c    |   5 +-
>>   pc-bios/s390-ccw/virtio-scsi.c   |   7 +-
>>   pc-bios/s390-ccw/virtio.c        | 209 +++++----------------------
>>   pc-bios/s390-ccw/Makefile        |   3 +-
>>   13 files changed, 367 insertions(+), 220 deletions(-)
>>   create mode 100644 pc-bios/s390-ccw/virtio-ccw.h
>>   create mode 100644 pc-bios/s390-ccw/virtio-ccw.c
>>
> This patch is doing quite a bit of different changes at once, making 
> it hard to review ... It would be nice if you could at least move the 
> "S390_IPL_TYPE_*" movement into a separate patch.
Sure, I can break this up.  I think your suggestions about removing the 
global variables by storing them in the VDev struct make sense. I'll 
split it into smaller patches and clean up the things you mentioned.

Thanks,
Jared Rossi