From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles
Date: Fri, 11 Sep 2020 13:19:57 +0200 [thread overview]
Message-ID: <9eabd611-8885-3569-3b14-3654a1e5c7fd@redhat.com> (raw)
In-Reply-To: <42d1edc2-228b-220c-8db8-251cb83c964b@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 560 bytes --]
On 11/09/20 13:05, Max Reitz wrote:
> On closer inspection it seems like it’s because of the
> “build_by_default: false”, which seems like a rather conscious decision.
> Was I only lucky that the socket_scm_helper was built by default so
> far? Should I have explicitly built it all this time?
Yes, you were lucky but that's not a reason not to change it.
The problem with touching a whole build system is that you are not going
to test everybody's usecase, and yours is definitely reasonable and not
"M-x butterfly" territory.
Paolo
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-11 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 17:53 [PULL v2 00/46] Next round of Meson bugfixes and cleanups Paolo Bonzini
2020-09-06 17:53 ` [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles Paolo Bonzini
2020-09-11 10:58 ` Max Reitz
2020-09-11 11:05 ` Max Reitz
2020-09-11 11:19 ` Paolo Bonzini [this message]
2020-09-11 11:17 ` Paolo Bonzini
2020-09-06 18:34 ` [PULL v2 00/46] Next round of Meson bugfixes and cleanups Peter Maydell
2020-09-07 2:56 ` 罗勇刚(Yonggang Luo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eabd611-8885-3569-3b14-3654a1e5c7fd@redhat.com \
--to=pbonzini@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).