Re: [PATCH v5 17/18] whpx: arm64: gicv3: add migration blocker

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 8/7/25 11:54 PM, Mohamed Mediouni wrote:
> GICv3 state save-restore is currently not implemented yet.
> 
> Signed-off-by: Mohamed Mediouni <mohamed@unpredictable.fr>
> ---
>   hw/intc/arm_gicv3_whpx.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/hw/intc/arm_gicv3_whpx.c b/hw/intc/arm_gicv3_whpx.c
> index 35dc5ac531..700b2a1a2f 100644
> --- a/hw/intc/arm_gicv3_whpx.c
> +++ b/hw/intc/arm_gicv3_whpx.c
> @@ -17,6 +17,7 @@
>   #include "system/whpx-internal.h"
>   #include "gicv3_internal.h"
>   #include "vgic_common.h"
> +#include "migration/blocker.h"
>   #include "qom/object.h"
>   #include "target/arm/cpregs.h"
>   
> @@ -228,6 +229,15 @@ static void whpx_gicv3_realize(DeviceState *dev, Error **errp)
>           error_setg(errp, "Nested virtualisation not currently supported by WHPX.");
>           return;
>       }
> +
> +    Error *whpx_migration_blocker = NULL;
> +
> +    error_setg(&whpx_migration_blocker,
> +        "Live migration disabled because GIC state save/restore not supported on WHPX");
> +    if (migrate_add_blocker(&whpx_migration_blocker, errp)) {
> +        error_free(whpx_migration_blocker);
> +        return;
> +    }
>   }
>   
>   static void whpx_gicv3_class_init(ObjectClass *klass, const void *data)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>