Re: [PATCH v2 4/4] hw/sparc*: Move cpu_check_irqs() to target/sparc/

[Richard Henderson <richard.henderson@linaro.org>]

On 4/28/21 7:16 AM, Philippe Mathieu-Daudé wrote:
> Since cpu_check_irqs() doesn't reference to anything outside
> of CPUSPARCState, it better belongs to the architectural code
> in target/, rather than the hardware specific code in hw/.
> 
> Note: while we moved the trace events, we don't rename them.
> 
> Remark: this allows us to build the leon3 machine stand alone,
> fixing this link failure (because cpu_check_irqs is defined in
> hw/sparc/sun4m.c which is only built when CONFIG_SUN4M is selected):
> 
>    /usr/bin/ld: target_sparc_win_helper.c.o: in function `cpu_put_psr':
>    target/sparc/win_helper.c:91: undefined reference to `cpu_check_irqs'
> 
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   hw/sparc/sun4m.c            | 32 ------------------
>   hw/sparc64/sparc64.c        | 66 -------------------------------------
>   target/sparc/int32_helper.c | 33 +++++++++++++++++++
>   target/sparc/int64_helper.c | 66 +++++++++++++++++++++++++++++++++++++
>   hw/sparc/trace-events       |  2 --
>   hw/sparc64/trace-events     |  4 ---
>   target/sparc/trace-events   |  8 +++++
>   7 files changed, 107 insertions(+), 104 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~