From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF05C43600 for ; Wed, 28 Apr 2021 14:54:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83B8961008 for ; Wed, 28 Apr 2021 14:54:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83B8961008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lblZo-0005Qd-Du for qemu-devel@archiver.kernel.org; Wed, 28 Apr 2021 10:54:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lblYp-00049o-SJ for qemu-devel@nongnu.org; Wed, 28 Apr 2021 10:53:07 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]:44646) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lblYo-0008Fh-AQ for qemu-devel@nongnu.org; Wed, 28 Apr 2021 10:53:07 -0400 Received: by mail-pf1-x42f.google.com with SMTP id m11so732185pfc.11 for ; Wed, 28 Apr 2021 07:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ipEGKqF6yIsN9R+Io8P8kjdHB51ztvNPey6/Zi2PWoc=; b=xkQrmrhyx6vT/fCrC6NiDZ6RtWDzcQNGcsCiQMj0EycNqH5PULilqs+NCH08kfrA5U WIWqysGfgURomhNMWpYvUbdJ3mtxsGZUuSRJtagAjXDwA0TWXR1phm4ui2iezBx5RI1e 5md8BghtOTwE9rlXjfLexztFfSvaU4yt2HCly7f4lTJOmrfrBSsg2Z6ivchN7jhwNv8w 63RTTV1hPwqGGGJI2camc7g1OqQKC/7do3ovpXuA+LuqTY1c0kw4rF+4XBReB7AZaRkz 4gg70a/2I6Cz7Q8DkXcvgTqtudFJ7iI57XHMCMrXhXXW68xJGmT+eGjL2bwNK+E5VThH kpDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ipEGKqF6yIsN9R+Io8P8kjdHB51ztvNPey6/Zi2PWoc=; b=BI3NNdOjYqhNAQOMHT0/NEjifckzszqP5C9ZsfqJhfrQTvyBbiraw/jEkbATSBoR3o DCjhk35mXNq3+ka1mbN3y4FW1IPF9SzLLF0UqtObNcJzasPj/dqcFEH7UueRabMf+sFz Lob53Gt8/lnM5YOnjtyRf3D3ZzZF5tcCUMsyLpVpfMgAsCCZVSN4dj+/skmiFPjUOXo/ J/lcH3L1S/Pk+Cdk1CAZZOAwPzpY0Cpyax/zY5udJImw3bP5V9Kzc1nnijUmIWWYrMLe oGuzYwitQzUF3uuB2HdeP3Wrl+wk0yeOuQIdxJOlAwgUw1TjxkfbSn0v537ocf9AwFPC NHkQ== X-Gm-Message-State: AOAM531eo9Zxlhxi6fKuFayAe0Exos4CINRYEXo4GSGrj8Y9Vkl8Lw9+ towgbra5ee6Wh+OK/HG/fz1WRQ== X-Google-Smtp-Source: ABdhPJxxzN0InyIPT3wZ4yrRXF60LfzTyfxTxltfYsECByW24A8xFTc2gR4pZViXJF+7YEi1Zy3KTA== X-Received: by 2002:a62:4c3:0:b029:27c:892f:8e22 with SMTP id 186-20020a6204c30000b029027c892f8e22mr4528102pfe.6.1619621584742; Wed, 28 Apr 2021 07:53:04 -0700 (PDT) Received: from [192.168.1.11] ([71.212.144.24]) by smtp.gmail.com with ESMTPSA id 18sm162004pji.30.2021.04.28.07.53.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 07:53:04 -0700 (PDT) Subject: Re: [PATCH v2 4/4] hw/sparc*: Move cpu_check_irqs() to target/sparc/ To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210428141655.387430-1-f4bug@amsat.org> <20210428141655.387430-5-f4bug@amsat.org> From: Richard Henderson Message-ID: <9ebea8b9-7481-3ea9-3e05-b08bd5ad4ac5@linaro.org> Date: Wed, 28 Apr 2021 07:53:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210428141655.387430-5-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: KONRAD Frederic , Mark Cave-Ayland , Thomas Huth , Fabien Chouteau , Artyom Tarasenko Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/28/21 7:16 AM, Philippe Mathieu-Daudé wrote: > Since cpu_check_irqs() doesn't reference to anything outside > of CPUSPARCState, it better belongs to the architectural code > in target/, rather than the hardware specific code in hw/. > > Note: while we moved the trace events, we don't rename them. > > Remark: this allows us to build the leon3 machine stand alone, > fixing this link failure (because cpu_check_irqs is defined in > hw/sparc/sun4m.c which is only built when CONFIG_SUN4M is selected): > > /usr/bin/ld: target_sparc_win_helper.c.o: in function `cpu_put_psr': > target/sparc/win_helper.c:91: undefined reference to `cpu_check_irqs' > > Suggested-by: Richard Henderson > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sparc/sun4m.c | 32 ------------------ > hw/sparc64/sparc64.c | 66 ------------------------------------- > target/sparc/int32_helper.c | 33 +++++++++++++++++++ > target/sparc/int64_helper.c | 66 +++++++++++++++++++++++++++++++++++++ > hw/sparc/trace-events | 2 -- > hw/sparc64/trace-events | 4 --- > target/sparc/trace-events | 8 +++++ > 7 files changed, 107 insertions(+), 104 deletions(-) Reviewed-by: Richard Henderson r~