From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>,
liu.dayu@zte.com.cn, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, jiang.xuexin@zte.com.cn
Subject: Re: Patch for qemu-project/qemu#2247 issue
Date: Tue, 2 Apr 2024 15:30:29 +0200 [thread overview]
Message-ID: <9ec42b31-f169-4d7d-82a4-f0173bc75581@linaro.org> (raw)
In-Reply-To: <291032f7-de3f-4b21-9b2e-872274203e37@tls.msk.ru>
On 2/4/24 11:59, Michael Tokarev wrote:
> 02.04.2024 12:50, Philippe Mathieu-Daudé пишет:
>> On 1/4/24 18:52, Michael Tokarev wrote:
>>> 01.04.2024 12:43, liu.dayu@zte.com.cn wrote:
>>>> hmp: Add help information for watchdog action: inject-nmi
>>>>
>>>> virsh qemu-monitor-command --hmp help information of watchdog_action
>>>> missing inject-nmi which already supported in Commit 795dc6e4
>>>>
>>>> Signed-off-by: Dayu Liu <liu.dayu@zte.com.cn>
>>>
>>> Applied to trivial-patches tree, in the following form:
>>>
>>> Author: Dayu Liu <liu.dayu@zte.com.cn>
>>> Date: Mon Apr 1 17:43:55 2024 +0800
>>>
>>> hmp: Add help information for watchdog action: inject-nmi
>>>
>>> virsh qemu-monitor-command --hmp help information of
>>> watchdog_action missing inject-nmi which already supported
>>> in Commit 795dc6e4
>>>
>>
>> Fixes: 795dc6e46d ("watchdog: Add new Virtual Watchdog action
>> INJECT-NMI")
>
> I don't think that commit is broken and needs Fixing.
> I see your point though - to have more formal way to
> mark "related" commits, it isn't always fixing something.
>
> I sent a pullreq for this a couple hours ago anyway.
No worries ;)
prev parent reply other threads:[~2024-04-02 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 9:43 Patch for qemu-project/qemu#2247 issue liu.dayu
2024-04-01 16:52 ` Michael Tokarev
2024-04-02 9:50 ` Philippe Mathieu-Daudé
2024-04-02 9:59 ` Michael Tokarev
2024-04-02 13:30 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ec42b31-f169-4d7d-82a4-f0173bc75581@linaro.org \
--to=philmd@linaro.org \
--cc=jiang.xuexin@zte.com.cn \
--cc=liu.dayu@zte.com.cn \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).