From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0194CD1284 for ; Tue, 2 Apr 2024 13:32:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rreDp-0000JW-41; Tue, 02 Apr 2024 09:30:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rreDm-0000IS-Ak for qemu-devel@nongnu.org; Tue, 02 Apr 2024 09:30:38 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rreDi-0000SN-Uf for qemu-devel@nongnu.org; Tue, 02 Apr 2024 09:30:37 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4161eb1aea7so1590445e9.0 for ; Tue, 02 Apr 2024 06:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712064632; x=1712669432; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7yV5DhXp84F08Csgrgf5l9tQgfG+5zMqa1qugWdzDL0=; b=rJm2n7DV9U0ODWzkdFoUUP7qtMfyeNFOOuHvzrPlPNWazIrhvt+AYkr1bvNiaK/HzL r0EdF7l9bPtxVTAUPkMm5Kkd2kg4NB0ClO/Hp/0j80lcul4xCUEu/Z7fm4c7Qniblsa0 nxeDfz60EPwUrQ9JwOAqePrw/SObdRQymtN22N7GUzROJXyqw7/odii9kiqA/xGeRjLV KNFEKE2cR/DClkERI1N2odWrOmhoanw7bw/ScVVYYRmeIVF+9nJANreC81+El7+dtkr3 resCMOhg3TSlfy+bu10OFuV19CB8oZlNNrHutE+9GR++PtbZwEF1mLcYA4fe/921Te78 FfOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712064632; x=1712669432; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7yV5DhXp84F08Csgrgf5l9tQgfG+5zMqa1qugWdzDL0=; b=JmiUUefaSHvtd3+mPzzllJthp/FQIe+Ycd46uhxtK1M06SbjYFOPmfNWa+uacKkVqK ryQkPDhZU+6b2m/wNrbZxzOS28mKsJziPevRjquOudjm9Fy7+d5uL9fLiq2XUY/nMxWY alOLconInmDRIKxz6DPBbJeig1fKnSi7rAVNECOqhOpm/Lbgt3Rn4fdKPqrMZty99GB/ DVSozu4sBSPvqHa5+dbdA98xK55qHLXuuVCgjzdUpn+9/q1BvUt7C5ls3DG4VCK+FWzI wqSWF0O5ZGafs6uT8QTTL3Ql9ibJDnZNCVazsl31M1hiLOfC11F5z93FesDpghUVxFPR 8Gng== X-Forwarded-Encrypted: i=1; AJvYcCV9FnVaNllO4zPJRggvLJMdCvGzKrR9bYRcbAwFYWIX7J4YUNraL3IicdLTtIlw9iSbNw7UowmcO/iRTk65tFQNzv2Jo4E= X-Gm-Message-State: AOJu0YzrF/rGYZHkuvSYa/47XQCxjJ2HxXScqy7I7iFvm/wQvGC/IcS4 moYgtOusLczooDbjVzJArEgOb5YQEs1SujuQh79aqbPYvX5gcoxBPgxvn3ZCY1Nw+T+d3E7ieWh mmjM= X-Google-Smtp-Source: AGHT+IEqXEFfetuczkoGQBa8L7Fc0uIIdMkhAHukdsYrGm6EfZd+FqNUlWRBhvqyQBziC9eTlEZAdg== X-Received: by 2002:a05:600c:3b02:b0:414:8abb:a96b with SMTP id m2-20020a05600c3b0200b004148abba96bmr8116028wms.34.1712064632074; Tue, 02 Apr 2024 06:30:32 -0700 (PDT) Received: from [192.168.69.100] ([176.187.202.91]) by smtp.gmail.com with ESMTPSA id q17-20020a05600c46d100b0041409db0349sm17959110wmo.48.2024.04.02.06.30.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Apr 2024 06:30:31 -0700 (PDT) Message-ID: <9ec42b31-f169-4d7d-82a4-f0173bc75581@linaro.org> Date: Tue, 2 Apr 2024 15:30:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Patch for qemu-project/qemu#2247 issue To: Michael Tokarev , liu.dayu@zte.com.cn, qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, jiang.xuexin@zte.com.cn References: <20240401174355899iU6IFrpOQSiGe36G4PToz@zte.com.cn> <298819da-145e-4478-901f-66241a23f03f@tls.msk.ru> <291032f7-de3f-4b21-9b2e-872274203e37@tls.msk.ru> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <291032f7-de3f-4b21-9b2e-872274203e37@tls.msk.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/4/24 11:59, Michael Tokarev wrote: > 02.04.2024 12:50, Philippe Mathieu-Daudé пишет: >> On 1/4/24 18:52, Michael Tokarev wrote: >>> 01.04.2024 12:43, liu.dayu@zte.com.cn wrote: >>>> hmp: Add help information for watchdog action: inject-nmi >>>> >>>> virsh qemu-monitor-command --hmp help information of watchdog_action >>>> missing inject-nmi which already supported in Commit 795dc6e4 >>>> >>>> Signed-off-by: Dayu Liu >>> >>> Applied to trivial-patches tree, in the following form: >>> >>> Author: Dayu Liu >>> Date:   Mon Apr 1 17:43:55 2024 +0800 >>> >>>      hmp: Add help information for watchdog action: inject-nmi >>> >>>      virsh qemu-monitor-command --hmp help information of >>>      watchdog_action missing inject-nmi which already supported >>>      in Commit 795dc6e4 >>> >> >> Fixes: 795dc6e46d ("watchdog: Add new Virtual Watchdog action >> INJECT-NMI") > > I don't think that commit is broken and needs Fixing. > I see your point though - to have more formal way to > mark "related" commits, it isn't always fixing something. > > I sent a pullreq for this a couple hours ago anyway. No worries ;)