From: Eric DeVolder <eric.devolder@oracle.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: ehabkost@redhat.com, mst@redhat.com, konrad.wilk@oracle.com,
qemu-devel@nongnu.org, pbonzini@redhat.com,
boris.ostrovsky@oracle.com, rth@twiddle.net
Subject: Re: [PATCH v5 06/10] ACPI ERST: build the ACPI ERST table
Date: Wed, 28 Jul 2021 10:18:48 -0500 [thread overview]
Message-ID: <9eea76b3-1c7f-e09a-f787-a2d3c0a1f2ec@oracle.com> (raw)
In-Reply-To: <20210727140127.3c97ef2f@redhat.com>
On 7/27/21 7:01 AM, Igor Mammedov wrote:
> On Mon, 26 Jul 2021 15:02:55 -0500
> Eric DeVolder <eric.devolder@oracle.com> wrote:
>
> [...]
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_BEGIN_READ_OPERATION:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_BEGIN_CLEAR_OPERATION:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_END_OPERATION:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_SET_RECORD_OFFSET:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER , 0, 32,
>>>>>> + s->bar0 + ERST_CSR_VALUE , 0, MASK32);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_EXECUTE_OPERATION:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_VALUE , ERST_EXECUTE_OPERATION_MAGIC, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_CHECK_BUSY_STATUS:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_READ_REGISTER_VALUE , 0, 32,
>>>>>> + s->bar0 + ERST_CSR_VALUE, 0x01, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_GET_COMMAND_STATUS:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_READ_REGISTER , 0, 32,
>>>>>> + s->bar0 + ERST_CSR_VALUE, 0, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_GET_RECORD_IDENTIFIER:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_READ_REGISTER , 0, 64,
>>>>>> + s->bar0 + ERST_CSR_VALUE, 0, MASK64);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_SET_RECORD_IDENTIFIER:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER , 0, 64,
>>>>>> + s->bar0 + ERST_CSR_VALUE , 0, MASK64);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_GET_RECORD_COUNT:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_READ_REGISTER , 0, 32,
>>>>>> + s->bar0 + ERST_CSR_VALUE, 0, MASK32);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_BEGIN_DUMMY_WRITE_OPERATION:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_RESERVED:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_GET_ERROR_LOG_ADDRESS_RANGE:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_READ_REGISTER , 0, 64,
>>>>>> + s->bar0 + ERST_CSR_VALUE, 0, MASK64);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_GET_ERROR_LOG_ADDRESS_LENGTH:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_READ_REGISTER , 0, 64,
>>>>>> + s->bar0 + ERST_CSR_VALUE, 0, MASK32);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_GET_ERROR_LOG_ADDRESS_RANGE_ATTRIBUTES:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_READ_REGISTER , 0, 32,
>>>>>> + s->bar0 + ERST_CSR_VALUE, 0, MASK32);
>>>>>> + break;
>>>>>> + case ACPI_ERST_ACTION_GET_EXECUTE_OPERATION_TIMINGS:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_WRITE_REGISTER_VALUE, 0, 32,
>>>>>> + s->bar0 + ERST_CSR_ACTION, action, MASK8);
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_READ_REGISTER , 0, 64,
>>>>>> + s->bar0 + ERST_CSR_VALUE, 0, MASK64);
>>>>>> + default:
>>>>>> + build_serialization_instruction_entry(table_data, action,
>>>>>> + ACPI_ERST_INST_NOOP, 0, 0, 0, action, 0);
>>>>>> + break;
>>>>>> + }
>
> ../../builds/imammedo/qemu/hw/acpi/erst.c: In function ‘build_erst’:
> ../../builds/imammedo/qemu/hw/acpi/erst.c:754:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
> build_serialization_instruction_entry(table_data, action,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ACPI_ERST_INST_READ_REGISTER , 0, 64,
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> s->bar0 + ERST_CSR_VALUE, 0, MASK64);
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../builds/imammedo/qemu/hw/acpi/erst.c:757:9: note: here
> default:
> ^~~~~~~
> cc1: all warnings being treated as errors
Michael pointed this one out last week, I've since corrected it.
>
>
>>>>>> + }
>>>>>> + build_header(linker, table_data,
>>>>>> + (void *)(table_data->data + erst_start),
>>>>>> + "ERST", table_data->len - erst_start,
>>>>>> + 1, oem_id, oem_table_id);
>>>>>> +}
>>>>>> +
>>>>>> +/*******************************************************************/
>>>>>> +/*******************************************************************/
>>>>>> +
>>>>>> static const VMStateDescription erst_vmstate = {
>>>>>> .name = "acpi-erst",
>>>>>> .version_id = 1,
>>>>>
>>>>
>>>
>>
>
next prev parent reply other threads:[~2021-07-28 15:19 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 19:07 [PATCH v5 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU Eric DeVolder
2021-06-30 19:07 ` [PATCH v5 01/10] ACPI ERST: bios-tables-test.c steps 1 and 2 Eric DeVolder
2021-06-30 19:07 ` [PATCH v5 02/10] ACPI ERST: specification for ERST support Eric DeVolder
2021-06-30 19:26 ` Eric DeVolder
2021-07-19 15:02 ` Igor Mammedov
2021-07-21 15:42 ` Eric DeVolder
2021-07-26 10:06 ` Igor Mammedov
2021-07-26 19:52 ` Eric DeVolder
2021-07-27 11:45 ` Igor Mammedov
2021-07-28 15:16 ` Eric DeVolder
2021-06-30 19:07 ` [PATCH v5 03/10] ACPI ERST: PCI device_id for ERST Eric DeVolder
2021-07-19 15:06 ` Igor Mammedov
2021-07-21 15:42 ` Eric DeVolder
2021-06-30 19:07 ` [PATCH v5 04/10] ACPI ERST: header file " Eric DeVolder
2021-06-30 19:07 ` [PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature Eric DeVolder
2021-07-20 12:17 ` Igor Mammedov
2021-07-21 16:07 ` Eric DeVolder
2021-07-26 10:42 ` Igor Mammedov
2021-07-26 20:01 ` Eric DeVolder
2021-07-27 12:52 ` Igor Mammedov
2021-08-04 22:13 ` Eric DeVolder
2021-08-05 9:05 ` Igor Mammedov
2021-07-21 17:36 ` Eric DeVolder
2021-07-26 10:13 ` Igor Mammedov
2021-06-30 19:07 ` [PATCH v5 06/10] ACPI ERST: build the ACPI ERST table Eric DeVolder
2021-07-20 13:16 ` Igor Mammedov
2021-07-20 14:59 ` Igor Mammedov
2021-07-21 16:12 ` Eric DeVolder
2021-07-26 11:00 ` Igor Mammedov
2021-07-26 20:02 ` Eric DeVolder
2021-07-27 12:01 ` Igor Mammedov
2021-07-28 15:18 ` Eric DeVolder [this message]
2021-06-30 19:07 ` [PATCH v5 07/10] ACPI ERST: trace support Eric DeVolder
2021-07-20 13:15 ` Igor Mammedov
2021-07-21 16:14 ` Eric DeVolder
2021-07-26 11:08 ` Igor Mammedov
2021-07-26 20:03 ` Eric DeVolder
2021-06-30 19:07 ` [PATCH v5 08/10] ACPI ERST: create ACPI ERST table for pc/x86 machines Eric DeVolder
2021-07-20 13:19 ` Igor Mammedov
2021-07-21 16:16 ` Eric DeVolder
2021-07-26 11:30 ` Igor Mammedov
2021-07-26 20:03 ` Eric DeVolder
2021-06-30 19:07 ` [PATCH v5 09/10] ACPI ERST: qtest for ERST Eric DeVolder
2021-07-20 13:38 ` Igor Mammedov
2021-07-21 16:18 ` Eric DeVolder
2021-07-26 11:45 ` Igor Mammedov
2021-07-26 20:06 ` Eric DeVolder
2021-06-30 19:07 ` [PATCH v5 10/10] ACPI ERST: step 6 of bios-tables-test.c Eric DeVolder
2021-07-20 13:24 ` Igor Mammedov
2021-07-21 16:19 ` Eric DeVolder
2021-07-13 20:38 ` [PATCH v5 00/10] acpi: Error Record Serialization Table, ERST, support for QEMU Michael S. Tsirkin
2021-07-21 15:23 ` Eric DeVolder
2021-07-20 14:57 ` Igor Mammedov
2021-07-21 15:26 ` Eric DeVolder
2021-07-23 16:26 ` Eric DeVolder
2021-07-27 12:55 ` Igor Mammedov
2021-07-28 15:19 ` Eric DeVolder
2021-07-29 8:07 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eea76b3-1c7f-e09a-f787-a2d3c0a1f2ec@oracle.com \
--to=eric.devolder@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).