From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwup0-0005hd-Qr for qemu-devel@nongnu.org; Tue, 17 Jun 2014 10:57:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wwuor-0004Pf-R0 for qemu-devel@nongnu.org; Tue, 17 Jun 2014 10:57:14 -0400 Received: from afflict.kos.to ([92.243.29.197]:46244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wwuor-0004PB-KO for qemu-devel@nongnu.org; Tue, 17 Jun 2014 10:57:05 -0400 From: riku.voipio@linaro.org Date: Tue, 17 Jun 2014 17:56:50 +0300 Message-Id: <9eeb8306d56e8fd831bbbac6e3cfe69a40312a33.1403016610.git.riku.voipio@linaro.org> In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PULL v2 07/17] signal/all/do_sigaltstack remove __get_user value check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Riku Voipio From: Riku Voipio Access is already checked in the lock_user_struct call before. Signed-off-by: Riku Voipio Reviewed-by: Peter Maydell --- linux-user/signal.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 2a1c681..f55076d 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -619,11 +619,12 @@ abi_long do_sigaltstack(abi_ulong uss_addr, abi_ulong uoss_addr, abi_ulong sp) struct target_sigaltstack ss; ret = -TARGET_EFAULT; - if (!lock_user_struct(VERIFY_READ, uss, uss_addr, 1) - || __get_user(ss.ss_sp, &uss->ss_sp) - || __get_user(ss.ss_size, &uss->ss_size) - || __get_user(ss.ss_flags, &uss->ss_flags)) + if (!lock_user_struct(VERIFY_READ, uss, uss_addr, 1)) { goto out; + } + __get_user(ss.ss_sp, &uss->ss_sp); + __get_user(ss.ss_size, &uss->ss_size); + __get_user(ss.ss_flags, &uss->ss_flags); unlock_user_struct(uss, uss_addr, 0); ret = -TARGET_EPERM; -- 2.0.0.rc2