From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 292B2C433B4 for ; Mon, 19 Apr 2021 20:07:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B3E461360 for ; Mon, 19 Apr 2021 20:07:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B3E461360 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bsdio.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYaB0-0003I8-Fr for qemu-devel@archiver.kernel.org; Mon, 19 Apr 2021 16:07:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYa9H-0002Ew-Ka; Mon, 19 Apr 2021 16:05:35 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:49514) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYa9F-0003mx-SG; Mon, 19 Apr 2021 16:05:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=H4h1DjIrtL0Fa0Yb5MbMUk1vUd2pdYsnrYWOLJ1HKeY=; b=BFGrf8NJgqM+wqT/Rnn7dmSL3V bUDCGs2Rh5MoWcVv7aZt6tSOLTGFYC6DgdUDIiZtDKjFacDX9pIwRWOkF7owmhTlvqCq1CWUKFRr7 pfK8N0CyrgZlm7MlAFZWxLARgGmSoq0HI8xFoO1eY8YSR9ok0YBREPSup1GuTjg1lLP0=; Received: from in02.mta.xmission.com ([166.70.13.52]) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lYa8w-00H0Mp-OS; Mon, 19 Apr 2021 14:05:14 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]) by in02.mta.xmission.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lYa8n-004OAv-At; Mon, 19 Apr 2021 14:05:14 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id 27C0C1281072; Mon, 19 Apr 2021 14:05:05 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UWHD52ZwvfEy; Mon, 19 Apr 2021 14:05:05 -0600 (MDT) Received: from [10.0.10.120] (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id D12C9128131C; Mon, 19 Apr 2021 14:05:04 -0600 (MDT) To: Rebecca Cran , peter.maydell@linaro.org, richard.henderson@linaro.org References: <20210414203231.824-1-rebecca@nuviainc.com> From: Rebecca Cran Message-ID: <9f0792fd-3b5a-3315-26bd-7c8307e7dae0@bsdio.com> Date: Mon, 19 Apr 2021 14:05:04 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210414203231.824-1-rebecca@nuviainc.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-XM-SPF: eid=1lYa8n-004OAv-At; ; ; mid=<9f0792fd-3b5a-3315-26bd-7c8307e7dae0@bsdio.com>; ; ; hst=in02.mta.xmission.com; ; ; ip=166.70.13.69; ; ; frm=rebecca@bsdio.com; ; ; spf=none X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com Subject: Re: [PATCH v7 0/4] Add support for FEAT_TLBIOS and FEAT_TLBIRANGE X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Received-SPF: none client-ip=166.70.13.233; envelope-from=rebecca@bsdio.com; helo=out03.mta.xmission.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Richard, Could you review this patch series again please? I've fixed several issues recently, and am interested to know if it's ready to commit or would need further changes. -- Rebecca Cran On 4/14/2021 2:32 PM, Rebecca Cran wrote: > ARMv8.4 adds the mandatory FEAT_TLBIOS and FEAT_TLBIRANGE. > They provides TLBI maintenance instructions that extend to the Outer > Shareable domain and that apply to a range of input addresses. > > Changes from v6 to v7: > > o Fixed the tlbi_aa64_rvae1_write the tlbi_aa64_rvae1is_write functions > to pass the correct value into functions which use an ARMMMUIdx. > > o Fixed comments in helper.c which referred to non-existent instructions. > > Testing: > > o Booted Linux 5.11 - verified the previous assert failure in qemu is > resolved. > o Ran checkpatch.pl. > > Rebecca Cran (4): > accel/tcg: Add TLB invalidation support for ranges of addresses > target/arm: Add support for FEAT_TLBIRANGE > target/arm: Add support for FEAT_TLBIOS > target/arm: set ID_AA64ISAR0.TLB to 2 for max AARCH64 CPU type > > accel/tcg/cputlb.c | 130 ++++++- > include/exec/exec-all.h | 46 +++ > target/arm/cpu.h | 10 + > target/arm/cpu64.c | 1 + > target/arm/helper.c | 371 ++++++++++++++++++++ > 5 files changed, 555 insertions(+), 3 deletions(-) >