From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5D2CC19F32 for ; Fri, 7 Mar 2025 11:47:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tqWA1-0000dF-IS; Fri, 07 Mar 2025 06:46:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqW9p-0000bj-7b; Fri, 07 Mar 2025 06:46:27 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqW9n-0006Aj-1W; Fri, 07 Mar 2025 06:46:24 -0500 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 527APISe019258; Fri, 7 Mar 2025 11:46:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=PmIvr8 s5kGRskjqHCbTFbYpXjoy2O2DjuAlRIIBolFs=; b=iMOgdLtCsPzFw7JsqjvBg4 DNgWIeaPp53WWQl9nNuEBvv9omrPKLUirbSbSSBlLE3DOuTz+kfF/Ws8VIC3jVsv ND5J/wN0vEh3z2NX0WfNWYKS54Cttj3cA8fs7m6z/8+cjWn4FWKdzA86V6zneQsN MVDRohVt7qpFteFZYEN/SoBJ5bI7oNcudF3dWr3zHJNgeLp34gaMNPgifzNxuQpS j8yU0OnvOcyg6+pCMjFHrZjbVQL6/b508bsH35Vz9PKR7oC1GiJr+Jp+4iI1+NOL zOCDf0MtbFWreHPrIGy+dNqWTrQnfT6Q+P72odMSNLAwk/5nEOc7bhYhxKZlGMhg == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 457d4p5uhh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Mar 2025 11:46:20 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 5279mSqH020911; Fri, 7 Mar 2025 11:46:18 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 454djnxm9h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Mar 2025 11:46:18 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 527BkH2o17957444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Mar 2025 11:46:17 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EB1AD5804B; Fri, 7 Mar 2025 11:46:16 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A72BD58059; Fri, 7 Mar 2025 11:46:15 +0000 (GMT) Received: from [9.61.127.211] (unknown [9.61.127.211]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 7 Mar 2025 11:46:15 +0000 (GMT) Message-ID: <9f2e7a33-9fa7-4391-a3df-8bcee757a222@linux.ibm.com> Date: Fri, 7 Mar 2025 06:46:15 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 3/5] hw/vfio/ap: store object indicating AP config changed in a queue To: Rorie Reyes , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, jjherne@linux.ibm.com, borntraeger@linux.ibm.com, alex.williamson@redhat.com, clg@redhat.com, thuth@redhat.com References: <20250204170759.36540-1-rreyes@linux.ibm.com> <20250204170759.36540-4-rreyes@linux.ibm.com> Content-Language: en-US From: Anthony Krowiak In-Reply-To: <20250204170759.36540-4-rreyes@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: R-w62gsqj5BRdl83inqssqt4weMp3Xvl X-Proofpoint-ORIG-GUID: R-w62gsqj5BRdl83inqssqt4weMp3Xvl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-07_04,2025-03-06_04,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503070082 Received-SPF: pass client-ip=148.163.156.1; envelope-from=akrowiak@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/4/25 12:07 PM, Rorie Reyes wrote: > Creates an object indicating that an AP configuration change event > has been received and stores it in a queue. These objects will later > be used to store event information for an AP configuration change > when the CHSC instruction is intercepted. > > Signed-off-by: Rorie Reyes > --- > hw/vfio/ap.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index a2b3735349..396fcf87de 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -41,6 +41,13 @@ struct VFIOAPDevice { > EventNotifier cfg_notifier; > }; > > +typedef struct APConfigChgEvent { > + QTAILQ_ENTRY(APConfigChgEvent) next; > +} APConfigChgEvent; > + > +QTAILQ_HEAD(, APConfigChgEvent) cfg_chg_events = > + QTAILQ_HEAD_INITIALIZER(cfg_chg_events); > + > OBJECT_DECLARE_SIMPLE_TYPE(VFIOAPDevice, VFIO_AP_DEVICE) > > static void vfio_ap_compute_needs_reset(VFIODevice *vdev) > @@ -75,11 +82,16 @@ static void vfio_ap_req_notifier_handler(void *opaque) > static void vfio_ap_cfg_chg_notifier_handler(void *opaque) > { > VFIOAPDevice *vapdev = opaque; > + APConfigChgEvent *cfg_chg_event = g_new0(APConfigChgEvent, 1); > > if (!event_notifier_test_and_clear(&vapdev->cfg_notifier)) { > - css_generate_css_crws(0); > + return; As I stated in my review of patch 2/5, the change above should have been done there. > } > > + QTAILQ_INSERT_TAIL(&cfg_chg_events, cfg_chg_event, next); > + > + css_generate_css_crws(0); Ditto. > + > } > > static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,