From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78B60C3ABA3 for ; Mon, 28 Apr 2025 11:42:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u9MsB-0002Wn-Gd; Mon, 28 Apr 2025 07:42:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9Ms7-0002TX-Ua for qemu-devel@nongnu.org; Mon, 28 Apr 2025 07:42:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u9Ms2-0008KV-Uk for qemu-devel@nongnu.org; Mon, 28 Apr 2025 07:42:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745840516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=R4PAlGWbevRoaBrxDCnbAFbZ3AIKlmXXxG7R6C5+158=; b=gUeuc8Vyw385islbAxKNR/N/hwrbXRORoTya7dGEixe3dZsZRkOOs6P1ZeLDE/HS1YHCG5 0ClxR/6u5r7ITRKUCzHDD2uZgmdjkouwZA1AifGRust6uqU85+8hp9dVhG9H6LpWii6ChV vWYM53Frv4Oh0O9/zojFMHcK6momgX0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-0t8zm_m1MKKlMPKJgpDmrQ-1; Mon, 28 Apr 2025 07:41:54 -0400 X-MC-Unique: 0t8zm_m1MKKlMPKJgpDmrQ-1 X-Mimecast-MFC-AGG-ID: 0t8zm_m1MKKlMPKJgpDmrQ_1745840513 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39123912ff0so1090633f8f.2 for ; Mon, 28 Apr 2025 04:41:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745840513; x=1746445313; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R4PAlGWbevRoaBrxDCnbAFbZ3AIKlmXXxG7R6C5+158=; b=Zp5fskaZSoEm05BflLlTMjiLm1wfxHx+Ozzx0S60oxe4X4bcd+RTmMBOeeMUjmjDkt a8erfAd2xr5J3QLOMy4zUDAqoHO3bu0KCBHF76+7ktofJ+tmYACX0VVTXRqI0llwZ5Cz fdHAGb+vUbFKp0zVcC0JqsqbvgnOREI2/SVDzSq3rlLcfe3gFMMAKJuT8g8ajOaH2aVY kgMroR4W7O8yPzL3WXlO8GOCfGwSaEd6VLzruxYXFnSA9myNpzjY1DNJQKSMQHhyau4n se21dWRHFeijDRY0GPp14VQMmsSJ3a55Owq559SLIUKzVv4iEQiznyFTrzQc63mrFT2I wFiA== X-Gm-Message-State: AOJu0YxOgvfFmAp47iHHZeRFTX1BWZdCJPxXI5vUI1ykQk6Z42YiKX9F KmuYLR4E1GOf252wETkyJ9QCLXNfD9rYLCnfhMNaX7+M8s/raofttfhT/bTo5jnggZVAh23AbLn +UCRiekBY5kcuieh6gYsoOaHiXkOsqj103NyUKZIOAekgg8S2jEDF X-Gm-Gg: ASbGnctjqzFqIOOfsN6eNbo+A00RBfRAxzXpF1DAbH6jlpDnzsud1h9ihlnitfNWgJA lCx5Kpay85QznObH08wvxJ2EHgWqWFVnMG/psVeEkbV7CRMNK9sIDILLM0VelGmjJzHw5i/9Hzy iIBmJcRzzh6Nb+vPghio2JgbUgoXyLzYyzcj8slLVO/sZgQ8lSKMsM1sbwYGZHbjQ0/Auwk8T6C ntX/ThVu9EZcWm9CkE6JeHo8IjGpInDd7KfTxPlLUNCh8tzqWbW4tzgngbAZpEWMlqQKeTgNnFw h5M8NEXUM9ayuIOUvM9faa72nO4Co8ACrhZgE+yqQZ8BOyKdfQ== X-Received: by 2002:a05:6000:144b:b0:39c:c64e:cf58 with SMTP id ffacd0b85a97d-3a074f8fb0amr10389733f8f.55.1745840512834; Mon, 28 Apr 2025 04:41:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUQsASKJ9YyMGaHdp3Zs29kqxWSL2jqLH8px8O/nftFhoUl1uj6NAG76FG/itt4wLYV/F7LQ== X-Received: by 2002:a05:6000:144b:b0:39c:c64e:cf58 with SMTP id ffacd0b85a97d-3a074f8fb0amr10389683f8f.55.1745840511869; Mon, 28 Apr 2025 04:41:51 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:3f78:514a:4f03:fdc0? ([2a01:e0a:280:24f0:3f78:514a:4f03:fdc0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073cbeda3sm11022372f8f.50.2025.04.28.04.41.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 04:41:51 -0700 (PDT) Message-ID: <9f36d6d9-8ec4-4c0e-a25a-481ffed82149@redhat.com> Date: Mon, 28 Apr 2025 13:41:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/14] vfio: specify VFIO_DMA_UNMAP_FLAG_ALL to callback To: John Levon Cc: qemu-devel@nongnu.org, Tony Krowiak , Stefano Garzarella , Peter Xu , Thomas Huth , Matthew Rosato , David Hildenbrand , "Michael S. Tsirkin" , Alex Williamson , qemu-s390x@nongnu.org, Tomita Moeko , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Halil Pasic , Jason Herne , Paolo Bonzini , Eric Farman References: <20250409134814.478903-1-john.levon@nutanix.com> <20250409134814.478903-8-john.levon@nutanix.com> <3cc6ed06-7ee4-42f4-a09e-03d8fe922537@redhat.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.484, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/24/25 21:35, John Levon wrote: > On Thu, Apr 24, 2025 at 07:16:52PM +0200, Cédric Le Goater wrote: > >>> Having said that I'm OK with going back to just a simple boolean if you'd really >>> prefer. >> >> yes. VFIO_DMA_UNMAP_FLAG_ALL is a kernel interface and we don't >> need more than one flag today. > > OK > >>>> Why not unmap the halves here instead of in the backends ? >>> >>> The whole point of the change is that right now the generic listener.c code has >>> a workaround that is specific to one particular backend. >> >> It's due to the ARM IO space size AFAICT. >> >>> vfio-user doesn't have >>> any need to unmap in halves and in fact *has* to pass an "unmap all" flag. >> >> OK. So this flag is a vfio-user requirement. Why can't we call >> vfio_container_dma_unmap() twice from vfio_listener_region_del() ? > > Are you suggesting that the vfio-user backend - and the protocol - somehow > accounts for the two unmaps and translates it back into an unmap all? How would > that work? ok. Let's keep that way. It's not too invasive a change. Thanks, C. > > Surely it's very ugly indeed to embed a foible of the (old) vfio kernel > interface into every backend. > > regards > john >