From: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>
Subject: Re: [PATCH] pci: SLT must be RO
Date: Mon, 2 Oct 2023 13:39:16 +0200 [thread overview]
Message-ID: <9f372453-4088-47d2-a501-c32eeaa5d9f5@linaro.org> (raw)
In-Reply-To: <42e00aaf-2399-4ba9-bef6-8627b8e0718e@linaro.org>
W dniu 8.09.2023 o 15:29, Marcin Juszkiewicz pisze:
> W dniu 31.08.2023 o 12:05, Marcin Juszkiewicz pisze:
>> W dniu 30.08.2023 o 23:48, Michael S. Tsirkin pisze:
>>> current code sets PCI_SEC_LATENCY_TIMER to WO, but for
>>> pcie to pcie bridges it must be RO 0 according to
>>> pci express spec which says:
>>> This register does not apply to PCI Express. It must be read-only
>>> and hardwired to 00h. For PCI Express to PCI/PCI-X Bridges,
>>> refer to the
>>> [PCIe-to-PCI-PCI-X-Bridge] for requirements for this register.
>>>
>>> also, fix typo in comment where it's make writeable - this typo
>>> is likely what prevented us noticing we violate this requirement
>>> in the 1st place.
>>>
>>> Reported-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>
>>> Marcin, could you pls test this patch with virt-8.1 and latest?
>>> Thanks a lot!
>>
>> Tested-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>>
>> sbsa-ref: PASS
>> virt: PASS
>> virt-8.1: FAIL (as expected)
>> virt-8.0: FAIL (as expected)
>
> Can we get this patch refreshed and merged?
ping?
next prev parent reply other threads:[~2023-10-02 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 21:48 [PATCH] pci: SLT must be RO Michael S. Tsirkin
2023-08-31 6:22 ` Philippe Mathieu-Daudé
2023-08-31 6:45 ` Michael S. Tsirkin
2023-08-31 8:10 ` Philippe Mathieu-Daudé
2023-08-31 10:05 ` Marcin Juszkiewicz
2023-09-08 13:29 ` Marcin Juszkiewicz
2023-10-02 11:39 ` Marcin Juszkiewicz [this message]
2023-10-02 22:28 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f372453-4088-47d2-a501-c32eeaa5d9f5@linaro.org \
--to=marcin.juszkiewicz@linaro.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).