[PATCH] iotests: Stop NBD server in test 162 before starting the next one

[PATCH] iotests: Stop NBD server in test 162 before starting the next one

[Thomas Huth]

Test 162 recently started failing for me for no obvious reasons (I
did not spot any suspicious commits in this area), but looking in
the 162.out.bad log file, there was a suspicious message at the end:

 qemu-nbd: Cannot lock pid file: Resource temporarily unavailable

And indeed, the test starts the NBD server two times, without stopping
the first server before running the second one, so the second one can
indeed fail to lock the PID file. Thus let's make sure to stop the
first server before the test continues with the second one. With this
change, the test works fine for me again.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/162 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162
index 94dae60d304..956c2c5f339 100755
--- a/tests/qemu-iotests/162
+++ b/tests/qemu-iotests/162
@@ -65,6 +65,7 @@ done
 
 $QEMU_IMG info "json:{'driver': 'nbd', 'host': 'localhost', 'port': $port}" \
     | grep '^image' | sed -e "s/$port/PORT/"
+_stop_nbd_server
 
 # This is a test for NBD's bdrv_refresh_filename() implementation: It expects
 # either host or path to be set, but it must not assume that they are set to
-- 
2.48.1

Re: [PATCH] iotests: Stop NBD server in test 162 before starting the next one

[Thomas Huth]

On 25/02/2025 08.06, Thomas Huth wrote:
> Test 162 recently started failing for me for no obvious reasons (I
> did not spot any suspicious commits in this area), but looking in
> the 162.out.bad log file, there was a suspicious message at the end:
> 
>   qemu-nbd: Cannot lock pid file: Resource temporarily unavailable
> 
> And indeed, the test starts the NBD server two times, without stopping
> the first server before running the second one, so the second one can
> indeed fail to lock the PID file. Thus let's make sure to stop the
> first server before the test continues with the second one. With this
> change, the test works fine for me again.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/qemu-iotests/162 | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162
> index 94dae60d304..956c2c5f339 100755
> --- a/tests/qemu-iotests/162
> +++ b/tests/qemu-iotests/162
> @@ -65,6 +65,7 @@ done
>   
>   $QEMU_IMG info "json:{'driver': 'nbd', 'host': 'localhost', 'port': $port}" \
>       | grep '^image' | sed -e "s/$port/PORT/"
> +_stop_nbd_server
>   
>   # This is a test for NBD's bdrv_refresh_filename() implementation: It expects
>   # either host or path to be set, but it must not assume that they are set to

By the way, this problem also seems to be caused by running configure with 
--enable-trace-backends=simple ... but I think stopping the previous server 
before running the next one is still a good idea.

  Thomas

Re: [PATCH] iotests: Stop NBD server in test 162 before starting the next one

[Eric Blake]

On Tue, Feb 25, 2025 at 08:06:50AM +0100, Thomas Huth wrote:
> Test 162 recently started failing for me for no obvious reasons (I
> did not spot any suspicious commits in this area), but looking in
> the 162.out.bad log file, there was a suspicious message at the end:
> 
>  qemu-nbd: Cannot lock pid file: Resource temporarily unavailable
> 
> And indeed, the test starts the NBD server two times, without stopping
> the first server before running the second one, so the second one can
> indeed fail to lock the PID file. Thus let's make sure to stop the
> first server before the test continues with the second one. With this
> change, the test works fine for me again.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qemu-iotests/162 | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org

Re: [PATCH] iotests: Stop NBD server in test 162 before starting the next one

[Eric Blake]

On Thu, Feb 27, 2025 at 01:14:12PM -0600, Eric Blake wrote:
> On Tue, Feb 25, 2025 at 08:06:50AM +0100, Thomas Huth wrote:
> > Test 162 recently started failing for me for no obvious reasons (I
> > did not spot any suspicious commits in this area), but looking in
> > the 162.out.bad log file, there was a suspicious message at the end:
> > 
> >  qemu-nbd: Cannot lock pid file: Resource temporarily unavailable
> > 
> > And indeed, the test starts the NBD server two times, without stopping
> > the first server before running the second one, so the second one can
> > indeed fail to lock the PID file. Thus let's make sure to stop the
> > first server before the test continues with the second one. With this
> > change, the test works fine for me again.
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  tests/qemu-iotests/162 | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Added to my NBD queue.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org