From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: Fam Zheng <fam@euphon.net>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build
Date: Mon, 7 Oct 2019 21:08:58 +0200 [thread overview]
Message-ID: <9f416e24-2c62-3bde-eda7-1a3e8dee47d1@redhat.com> (raw)
In-Reply-To: <877e5gjs0p.fsf@linaro.org>
On 10/7/19 9:05 PM, Alex Bennée wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> On Mon, 7 Oct 2019 at 17:22, Alex Bennée <alex.bennee@linaro.org> wrote:
>>>
>>> Adding debug makes things run a bit slower so lets not hammer all the
>>> targets.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>> .travis.yml | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index d0b9e099b9..fc0888aff5 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -124,12 +124,13 @@ matrix:
>>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>
>>>
>>> + # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
>>> - env:
>>> - - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
>>> + - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
>>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
>>
>> If (as noted in the comment) --enable-debug implies
>> --enable-debug-tcg, why do we need to give both options ?
>
> We don't really - I was just being verbose. I'll drop it.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
prev parent reply other threads:[~2019-10-07 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 16:07 [PATCH] .travis.yml: reduce scope of the --enable-debug build Alex Bennée
2019-10-07 16:25 ` Peter Maydell
2019-10-07 19:05 ` Alex Bennée
2019-10-07 19:08 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f416e24-2c62-3bde-eda7-1a3e8dee47d1@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).