qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Krasnyansky <maxk@kernel.org>
To: anthony@codemonkey.ws, qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, Max Krasnyansky <maxk@kernel.org>
Subject: [Qemu-devel] [PATCH 7/8] husb: Fixup printfs and stuff based on the review comments
Date: Fri, 15 Aug 2008 00:51:49 +0000	[thread overview]
Message-ID: <9f4f72cd762dd3a134c4a9c996a8980e1ad5b55c.1218760447.git.maxk@kernel.org> (raw)
In-Reply-To: <cover.1218760447.git.maxk@kernel.org>
In-Reply-To: <cover.1218760447.git.maxk@kernel.org>

Addressing Anthony's comments regarding printf and stuff.

Anthony, if you you want I can fold this commit and resend
the original patch.

Signed-off-by: Max Krasnyansky <maxk@kernel.org>
---
 usb-linux.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index dd78bb6..c31d56a 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -272,7 +272,7 @@ static int usb_host_update_interfaces(USBHostDevice *dev, int configuration)
     }
 
     if (i >= dev->descr_len) {
-        printf("husb: update iface failed. no matching configuration\n");
+        fprintf(stderr, "husb: update iface failed. no matching configuration\n");
         goto fail;
     }
     nb_interfaces = dev->descr[i + 4];
@@ -815,9 +815,6 @@ static int usb_host_auto_scan(void *opaque, int bus_num, int addr,
         return 0;
 
     for (f = usb_auto_filter; f; f = f->next) {
-        // printf("Auto match: bus_num %d addr %d vid %d pid %d\n",
-	//    bus_num, addr, vendor_id, product_id);
-
 	if (f->bus_num >= 0 && f->bus_num != bus_num)
             continue;
 
@@ -860,8 +857,8 @@ static void usb_host_auto_add(int bus_num, int addr, int vendor_id, int product_
 {
     struct USBAutoFilter *f = qemu_mallocz(sizeof(*f));
     if (!f) {
-        printf("husb: failed to allocate auto filter\n");
-	return;
+        fprintf(stderr, "husb: failed to allocate auto filter\n");
+        return;
     }
 
     f->bus_num = bus_num;
@@ -878,7 +875,7 @@ static void usb_host_auto_add(int bus_num, int addr, int vendor_id, int product_
          */
 	usb_auto_timer = qemu_new_timer(rt_clock, usb_host_auto_timer, NULL);
 	if (!usb_auto_timer) {
-            printf("husb: failed to allocate timer\n");
+            fprintf(stderr, "husb: failed to allocate auto scan timer\n");
             qemu_free(f);
             return;
         }
-- 
1.5.5.1

  parent reply	other threads:[~2008-08-15  0:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15  0:51 [Qemu-devel] [PATCH 0/8] Various USB fixes and improvements (update 2) Max Krasnyansky
2008-08-15  0:51 ` [Qemu-devel] [PATCH 1/8] husb: support for USB host device auto disconnect Max Krasnyansky
2008-08-15  0:51 ` [Qemu-devel] [PATCH 2/8] husb: support for USB host device auto connect Max Krasnyansky
2008-08-15  0:51 ` [Qemu-devel] [PATCH 3/8] usb: generic packet handler cleanup and documentation Max Krasnyansky
2008-08-15  0:51 ` [Qemu-devel] [PATCH 4/8] uhci: rewrite UHCI emulator, fully async operation with multiple outstanding transactions Max Krasnyansky
2008-08-15  0:51 ` [Qemu-devel] [PATCH 5/8] husb: rewrite Linux host USB layer, fully async operation Max Krasnyansky
2008-08-15  0:51 ` [Qemu-devel] [PATCH 6/8] husb: remove disconnect detection timer Max Krasnyansky
2008-08-15  0:51 ` Max Krasnyansky [this message]
2008-08-15  0:51 ` [Qemu-devel] [PATCH 8/8] uhci: fixes for save/load-vm Max Krasnyansky
2008-08-18 14:02 ` [Qemu-devel] Re: [PATCH 0/8] Various USB fixes and improvements (update 2) Anthony Liguori
2008-08-18 14:14   ` Ian Jackson
2008-08-18 18:57   ` Max Krasnyansky
2008-08-21 18:44     ` Anthony Liguori
2008-08-21 19:36 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f4f72cd762dd3a134c4a9c996a8980e1ad5b55c.1218760447.git.maxk@kernel.org \
    --to=maxk@kernel.org \
    --cc=anthony@codemonkey.ws \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).