From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTnYA-0006VH-Dk for qemu-devel@nongnu.org; Thu, 14 Aug 2008 20:52:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTnY4-0006S1-O5 for qemu-devel@nongnu.org; Thu, 14 Aug 2008 20:52:15 -0400 Received: from [199.232.76.173] (port=40179 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTnY3-0006Rq-Qk for qemu-devel@nongnu.org; Thu, 14 Aug 2008 20:52:12 -0400 Received: from hera.kernel.org ([140.211.167.34]:55252) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTnY3-0001eM-BL for qemu-devel@nongnu.org; Thu, 14 Aug 2008 20:52:11 -0400 From: Max Krasnyansky Date: Fri, 15 Aug 2008 00:51:49 +0000 Message-Id: <9f4f72cd762dd3a134c4a9c996a8980e1ad5b55c.1218760447.git.maxk@kernel.org> In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH 7/8] husb: Fixup printfs and stuff based on the review comments Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws, qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Max Krasnyansky Addressing Anthony's comments regarding printf and stuff. Anthony, if you you want I can fold this commit and resend the original patch. Signed-off-by: Max Krasnyansky --- usb-linux.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index dd78bb6..c31d56a 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -272,7 +272,7 @@ static int usb_host_update_interfaces(USBHostDevice *dev, int configuration) } if (i >= dev->descr_len) { - printf("husb: update iface failed. no matching configuration\n"); + fprintf(stderr, "husb: update iface failed. no matching configuration\n"); goto fail; } nb_interfaces = dev->descr[i + 4]; @@ -815,9 +815,6 @@ static int usb_host_auto_scan(void *opaque, int bus_num, int addr, return 0; for (f = usb_auto_filter; f; f = f->next) { - // printf("Auto match: bus_num %d addr %d vid %d pid %d\n", - // bus_num, addr, vendor_id, product_id); - if (f->bus_num >= 0 && f->bus_num != bus_num) continue; @@ -860,8 +857,8 @@ static void usb_host_auto_add(int bus_num, int addr, int vendor_id, int product_ { struct USBAutoFilter *f = qemu_mallocz(sizeof(*f)); if (!f) { - printf("husb: failed to allocate auto filter\n"); - return; + fprintf(stderr, "husb: failed to allocate auto filter\n"); + return; } f->bus_num = bus_num; @@ -878,7 +875,7 @@ static void usb_host_auto_add(int bus_num, int addr, int vendor_id, int product_ */ usb_auto_timer = qemu_new_timer(rt_clock, usb_host_auto_timer, NULL); if (!usb_auto_timer) { - printf("husb: failed to allocate timer\n"); + fprintf(stderr, "husb: failed to allocate auto scan timer\n"); qemu_free(f); return; } -- 1.5.5.1