From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b9q3m-0003iw-Oy
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:38:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b9q3i-0001Xd-FA
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:38:58 -0400
Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:34920)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1b9q3i-0001XX-7t
	for qemu-devel@nongnu.org; Mon, 06 Jun 2016 04:38:54 -0400
Received: by mail-wm0-x235.google.com with SMTP id c74so34298478wme.0
	for <qemu-devel@nongnu.org>; Mon, 06 Jun 2016 01:38:54 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <cover.1464242913.git.amit.shah@redhat.com>
	<d59ce6f34434bf47a9b26138c908650bf9a24be1.1464242913.git.amit.shah@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <9f545c67-b14a-edc4-db61-6fbcbff0a066@redhat.com>
Date: Mon, 6 Jun 2016 10:38:49 +0200
MIME-Version: 1.0
In-Reply-To: <d59ce6f34434bf47a9b26138c908650bf9a24be1.1464242913.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 10/28] migration: add reporting of errors
 for outgoing migration
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu list <qemu-devel@nongnu.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela <quintela@redhat.com>

On 26/05/2016 08:12, Amit Shah wrote:
> @@ -863,12 +867,15 @@ static void migrate_fd_cleanup(void *opaque)
>      notifier_list_notify(&migration_state_notifiers, s);
>  }
>  
> -void migrate_fd_error(MigrationState *s)
> +void migrate_fd_error(MigrationState *s, const Error *error)
>  {
> -    trace_migrate_fd_error();
> +    trace_migrate_fd_error(error ? error_get_pretty(error) : "");

This check on error == NULL is unnecessary, the only caller passes a
non-NULL error.

Paolo