From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vnc: generalize "VNC server running on ..." message
Date: Mon, 6 Jun 2016 16:08:40 +0200 [thread overview]
Message-ID: <9f55fd2f-21d3-a1cb-7f71-8c91fc95767e@redhat.com> (raw)
In-Reply-To: <20160606120629.GC5581@redhat.com>
On 06/06/2016 14:06, Daniel P. Berrange wrote:
>> > @@ -3838,6 +3834,10 @@ void vnc_display_open(const char *id, Error **errp)
>> > }
>> > }
>> >
>> > + if (show_vnc_port) {
>> > + vnc_display_print_local_addr(vs);
>> > + }
>> > +
>> > qapi_free_SocketAddress(saddr);
>> > qapi_free_SocketAddress(wsaddr);
>> > return;
> By calling this from vnc_display_open, you'll cause it to
> print to stdout, even when using QMP, because qmp_change_vnc_listen
> calls vnc_display_open.
Hmm, yes. Markus, what's the best thing to do? Some kind of
monitor_printf?
Thanks,
Paolo
next prev parent reply other threads:[~2016-06-06 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 12:01 [Qemu-devel] [PATCH] vnc: generalize "VNC server running on ..." message Paolo Bonzini
2016-06-06 12:06 ` Daniel P. Berrange
2016-06-06 14:08 ` Paolo Bonzini [this message]
2016-06-06 15:07 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f55fd2f-21d3-a1cb-7f71-8c91fc95767e@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).