Re: [PATCH v1 09/12] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to migrate

[Thomas Huth <thuth@redhat.com>]

On 05/08/2021 17.28, David Hildenbrand wrote:
> Let's use the guest_phys_blocks API to get physical memory regions
> that are well defined inside our physical address space and migrate the
> storage keys of these.
> 
> This is a prepearation for having memory besides initial ram defined in

s/prepearation/preparation/

> the guest physical address space, for example, via memory devices. We
> get rid of the ms->ram_size dependency.
> 
> Please note that we will usually have very little (--> 1) physical
> ranges. With virtio-mem might have significantly more ranges in the
> future. If that turns out to be a problem (e.g., total memory
> footprint of the list), we could look into a memory mapping
> API that avoids creation of a list and instead triggers a callback for
> each range.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>   hw/s390x/s390-skeys.c | 70 ++++++++++++++++++++++++++-----------------
>   1 file changed, 43 insertions(+), 27 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>