From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>,
Anton Nefedov <anton.nefedov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, stefanha@redhat.com,
famz@redhat.com, berto@igalia.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] iotest 033: add misaligned write-zeroes test via truncate
Date: Mon, 12 Mar 2018 17:01:39 -0500 [thread overview]
Message-ID: <9f72081b-899c-9423-cb1b-561afd8f5b2b@redhat.com> (raw)
In-Reply-To: <a69e1300-dbb2-ee8e-8b47-386bb431907a@redhat.com>
On 02/23/2018 07:34 AM, Max Reitz wrote:
> On 2018-02-12 14:14, Anton Nefedov wrote:
>> This new test case only makes sense for qcow2 while iotest 033 is generic;
>> however it matches the test purpose perfectly and also 033 contains those
>> do_test() tricks to pass the alignment, which won't look nice being
>> duplicated in other tests or moved to the common code.
>>
>> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
>> ---
>
> There should be a _cleanup_test_img before this or this test will fail
> with nbd.
Thanks for spotting that; patch posted:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03688.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-12 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 13:13 [Qemu-devel] [PATCH v2 0/2] block: fix write with zero flag set and iovector provided Anton Nefedov
2018-02-12 13:14 ` [Qemu-devel] [PATCH v2 1/2] iotest 033: add misaligned write-zeroes test via truncate Anton Nefedov
2018-02-12 15:54 ` Alberto Garcia
2018-02-12 16:16 ` Anton Nefedov
2018-02-23 13:34 ` Max Reitz
2018-03-12 22:01 ` Eric Blake [this message]
2018-02-12 13:14 ` [Qemu-devel] [PATCH v2 2/2] block: fix write with zero flag set and iovector provided Anton Nefedov
2018-02-12 15:03 ` Alberto Garcia
2018-02-12 16:11 ` Anton Nefedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f72081b-899c-9423-cb1b-561afd8f5b2b@redhat.com \
--to=eblake@redhat.com \
--cc=anton.nefedov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).