From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrange" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake
Date: Thu, 1 Mar 2018 18:22:40 +0100 [thread overview]
Message-ID: <9f7e7e3d-01a9-e73e-48e5-9aa8d86b561d@redhat.com> (raw)
In-Reply-To: <20180301084438.13594-12-peterx@redhat.com>
On 01/03/2018 09:44, Peter Xu wrote:
> +/**
> + * qio_channel_tls_handshake_full:
> + * @ioc: the TLS channel object
> + * @func: the callback to invoke when completed
> + * @opaque: opaque data to pass to @func
> + * @destroy: optional callback to free @opaque
> + * @context: the context that TLS handshake will run with
> + *
> + * Similar to qio_channel_tls_handshake(), but allows the task to be
> + * run on a specific context.
> + */
> +void qio_channel_tls_handshake_full(QIOChannelTLS *ioc,
> + QIOTaskFunc func,
> + gpointer opaque,
> + GDestroyNotify destroy,
> + GMainContext *context);
> +
You're not consistent in introducing "_full" functions. I would
add the argument directly to the qio_channel_tls_handshake() function.
Paolo
next prev parent reply other threads:[~2018-03-01 17:22 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 8:44 [Qemu-devel] [PATCH v2 00/15] qio: general non-default GMainContext support Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 01/15] chardev: fix leak in tcp_chr_telnet_init_io() Peter Xu
2018-03-01 17:39 ` Paolo Bonzini
2018-03-02 3:46 ` Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 02/15] qio: rename qio_task_thread_result Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 03/15] qio: introduce qio_channel_add_watch_{full|source} Peter Xu
2018-03-01 15:37 ` Daniel P. Berrangé
2018-03-01 17:13 ` Paolo Bonzini
2018-03-02 3:54 ` Peter Xu
2018-03-02 11:15 ` Paolo Bonzini
2018-03-02 15:44 ` Daniel P. Berrangé
2018-03-02 15:53 ` Paolo Bonzini
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 04/15] migration: let incoming side use thread context Peter Xu
2018-03-01 16:03 ` Daniel P. Berrangé
2018-03-02 3:56 ` Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 05/15] qio: refactor net listener source operations Peter Xu
2018-03-01 10:47 ` Daniel P. Berrangé
2018-03-02 3:58 ` Peter Xu
2018-03-02 4:04 ` Peter Xu
2018-03-02 10:51 ` Daniel P. Berrangé
2018-03-05 5:34 ` Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 06/15] qio: store gsources for net listeners Peter Xu
2018-03-01 15:40 ` Daniel P. Berrangé
2018-03-01 17:12 ` Paolo Bonzini
2018-03-02 4:10 ` Peter Xu
2018-03-02 4:59 ` Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 07/15] qio/chardev: update net listener gcontext Peter Xu
2018-03-01 15:43 ` Daniel P. Berrangé
2018-03-02 4:26 ` Peter Xu
2018-03-02 11:17 ` Paolo Bonzini
2018-03-05 5:43 ` Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switch gcontext Peter Xu
2018-03-01 15:46 ` Daniel P. Berrangé
2018-03-01 17:16 ` Paolo Bonzini
2018-03-02 4:37 ` Peter Xu
2018-03-02 11:02 ` Daniel P. Berrangé
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 09/15] qio: non-default context for threaded qtask Peter Xu
2018-03-01 15:47 ` Daniel P. Berrangé
2018-03-01 17:18 ` Paolo Bonzini
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 10/15] qio: non-default context for async conn Peter Xu
2018-03-01 15:48 ` Daniel P. Berrangé
2018-03-02 5:01 ` Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake Peter Xu
2018-03-01 15:50 ` Daniel P. Berrangé
2018-03-02 6:18 ` Peter Xu
2018-03-01 17:22 ` Paolo Bonzini [this message]
2018-03-02 6:09 ` Peter Xu
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 12/15] chardev: introduce chr_machine_done hook Peter Xu
2018-03-01 17:38 ` Paolo Bonzini
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 13/15] char: use chardev's gcontext for async connect Peter Xu
2018-03-01 17:38 ` Paolo Bonzini
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 14/15] chardev: tcp: postpone async connection setup Peter Xu
2018-03-01 16:01 ` Daniel P. Berrangé
2018-03-02 6:27 ` Peter Xu
2018-03-01 17:38 ` Paolo Bonzini
2018-03-01 8:44 ` [Qemu-devel] [PATCH v2 15/15] chardev: tcp: postpone TLS work until machine done Peter Xu
2018-03-01 16:03 ` Daniel P. Berrangé
2018-03-02 6:34 ` Peter Xu
2018-03-01 17:37 ` Paolo Bonzini
2018-03-02 6:43 ` Peter Xu
2018-03-01 16:07 ` [Qemu-devel] [PATCH v2 00/15] qio: general non-default GMainContext support Daniel P. Berrangé
2018-03-02 6:48 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f7e7e3d-01a9-e73e-48e5-9aa8d86b561d@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).